mass edit deletes checkbox and reference (uitype 10) fields

Even if not selected for update, checkboxes are set to "no" and reference fields are deleted.

The bug was introduced in this commit: !47694b79 and has relation to issues #1349 (closed) and #1241 (closed)

mentioned in merge request !733 (merged)

mentioned in commit 7441727b

mentioned in commit 9df3a4d2

@ruben.estrada Issue exists even after the fix, Please do validate.

Hi Uma, I have tested again. It's working for me:

Accounts list:

Selecting the first two accounts:

Modifying only the first name:

Final result does not clear the "Do Not Call" checkbox or the "Organization Name" Field:

Looking at the request headers, you can see that the only field included is firstname:

The problem before was that fields that had hidden input fields in the edit form were also added to the request. Those were avoided by modifying a jQuery selector that retrieves the needed hidden inputs for the mass save action request, i.e, these ones:

@ruben.estrada Your right, It may be cache issue i think. I couldn't able to reproduce now.

That's good! Thanks! Sorry for the bug in the firs place :(

@ruben.estrada No issues, your welcome for the fix.

Status changed to closed

I have tested after latest patch on multi-select combo box and it not working. Not much to describe, just try whatever scenario with multiselect field.

@ruben.estrada Yes! As Tony reported we could able to reproduce this case, On editing multi-combo field, values will be erased. Additionally updated multi combo fields values throws warning as 'None of fields changed'. Please refer to this screenRef

please do validate with all field types.

Hi Uma,

yes I was also able to reproduce the error.

I could also see that mass edit was not working for multiselect fields even before version 7.3. When selecting more than one option, only the last one was being saved.

I'll take a look into this again. I'll be sure to check every field type this time.

@ruben.estrada Hi Ruben,

I agree that the Multi-select fields had issue with Mass-edit save before version 7.3.0. But this issue has been addressed in 7.3.0 Ref

mentioned in merge request !736 (merged)

@uma.s @tonysandman

I've made a new MR: !736 (merged) and marked it as WIP.

I tested it with as many different type of fields I could and it seems to be working correctly with all of them. Please help me doing some more tests on your side and let me know if you find any other bug.

Status changed to reopened

Did more testing and everything looks good.

@ruben.estrada Thanks! for the fix. I have reviewed the changes and also tested with all field types for Contacts module that works fine!

Please do remove [WIP] so we can merge. But again we need to go with hotfix :(

mentioned in commit 1f985e8c

mentioned in commit 22a2da38

Milestone changed to 7.3.0 Hotfix2

Status changed to closed