updating CRMEntity.php to improve merging duplicates
updating CRMEntity.php to change transferRelatedRecords() function to deal with new related fields and custom modules fixes #1577
Merge request reports
Activity
@Martin.allen Thanks! for sharing the merge request.
As this is the change related to core file, We would recommend to list down the validation case scenarios that has been covered. So that we can review more closely before pull and get ideas from community on missing peices.
@uma.s I checked this by merging records from default modules that had new related fields added, and ensuring that where they were linked to the records being merge they updated correctly. Then where we had created Custom modules, ensuring that the related fields in them also updated correctly, where they were linked to the records being merged. So far we have not seen any issues with this change, and seems to work correctly.
-
@Martin.allen Thanks! for validation cases, We will take it forward.
2050 2050 $parmodule = $adb->query_result($parentRecords, $i, 'module'); 2051 2051 $adb->pquery("UPDATE vtiger_crmentityrel SET relcrmid=? WHERE crmid=? AND module=? AND relcrmid=? AND relmodule=?", array($entityId, $parcrmid, $parmodule, $transferId, $module)); 2052 2052 } 2053 $adb->pquery("UPDATE vtiger_modcomments SET related_to = ? WHERE related_to = ?", array($entityId, $transferId)); 2054 2053 } -
@Martin.allen As this peice of code is removed, porting the comments on merge will break right? Please do let me known about your observation.
-
@Martin.allen We have validated various test-cases with respect to related fields in custom module and as well default module that looks fine. Where as i have one query to be answered to get it merged.
-
@Martin.allen We have validated with modcomments as well, Your recommended changes successfully ports comments data.
Thanks! for the merge request. We are happy to intergrate this to 7.4.0
mentioned in commit 02b5fa15
@Martin.allen Hello, tried with custom module and didn't work. Will inspect further.
@Martin.allen Works for custom Modules inside Standard Module. Doesn´t work for Duplicates records (Custom Module).
Lets say you create a custom module (Modcat) and each Modcat record (2) has one document related. If you merge those two Modcat records, you end up with only one Document related.
Regards