Cleaning up #1301
I tested this on a recent pull and it seems to be working correctly.
Merge request reports
Activity
@lord_alan Merge request looks fine, Why not move the helper api to include/utils/utils.php instead of SaveAjax.php, Please do review on this note and remove WIP in Merge request.
@uma.s Well, include/utils/utils.php is completely outside the scope of vtiger's MVC architecture and as this API seems only to be needed in the two child clasees here so I thought why infect code elsewhere in vtiger?
@lord_alan That's right but i felt this will be useful in future. Anyhow for now we can go ahead with change.
Please do submit the merge request, once your done with validation.
Title changed from WIP: First attempt at cleaning up #1301 (closed) to Cleaning up #1301 (closed)
@uma.s tested and seems to be working OK.
Added 1 commit:
- b5c4d979 - Fix activityType definitions. Refs #1295 (closed)
@uma.s I added some fixes for #1295 (closed) (activitytype <> $activityType).
@lord_alan Thank you, will review.
mentioned in commit 30cf5636