Wrong method signature in migration module

If I use PHP7.3, I cant migrate. There are a wrong function call.
In modules/Migration/models/Module.php is a function:
public static function getInstance($value)
but in modules/Migration/views/Index.php is a call
$migrationModuleModel = Migration_Module_Model::getInstance();

Maybe PHP5.6 tollerate it, but PHP7.3 does not

I don't think vtiger is compatible with php 7.3. Not even with php7.1.

To be on the save side use php 5.6 or php 7.0.

Ruben, PHP 5.6/7.0/7.1 are EOL. 7.2 end of this year too. I think its time to make Vtiger compatible with a current PHP.
We are working with PHP 5.6, but my test system works with 7.3. In last time this was the first issue with php 7.3

FWIW, vtiger works fine on php-7.2

Thx that you confirm that Vtiger works fine on PHP 7.2

@daniel.voelskow I've spent quite a while referring issues with method signatures to vtiger (they are reported as deprecated in 7.2) so most should now be fixed but there may be a few left over. Maybe change the title of the ticket to include the fact this is about a method signature?

@uma.s See above. It sounds like php7.3 will not allow inconsistent method signatures.

Title changed from Cant migrate with PHP7.3 to Wrong method signature in migration module

@lord_alan is this title now ok?

Btw, this here shows incompatible too: Got error 'PHP message: PHP Warning: Declaration of Reports_Record_Model::getInstanceById(

$recordId) should be compatible with Vtiger_Record_Model::getInstanceById($

recordId, $module = NULL) in modules/Reports/models/Record.php on line 0', referer:...

👍

@lord_alan When you say it works fine with php 7.2, what version of vtiger are you referring to? I reported this issue a few months ago: http://vtiger-crm.2324883.n4.nabble.com/Vtigercrm-developers-vtiger-compatibility-with-php-7-1-td22481.html#a22484

Dragging and dropping calendar events to reschedule wouldn't work back then when using php 7.1.

@ruben.estrada I check this with PHP 7.3
Drag&Drop with calendar events works with the actualy git/master, but in log it shows a error:
Got error 'PHP message: PHP Warning: Use of undefined constant activitytype - assumed 'activitytype' (this will throw an Error in a future version of PHP) in modules/Calendar/actions/DragDropAjax.php on line 270', referer: http://vtiger-test/index.php?module=Calendar&view=Calendar

@ruben.estrada Drag and Drop works for me on php7.2 (vtiger 7.2.0)

@daniel.voelskow That is a "warning" not an error. It should be fixed I agree, but there is a big difference between a warning and an error message.

@uma.s This line is wrong:

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Calendar/actions/DragDropAjax.php#L270

Should be "$activityType" which is defined here:

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Calendar/actions/DragDropAjax.php#L180

@daniel.voelskow I checked through the static api declaration and call in php 7.3, Where this looks fine. As the signature of api is pubilc static and we are making call through scope resolution operator(::) should work fine.

Can you please get me through some reference on why is this breaking? I couldn't find one.

@lord_alan @ruben.estrada

@uma.s I think the issue is that the getInstance method expects one argument to be passed in ($value):

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Migration/models/Module.php#L28

But it is called here with no argument:

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Migration/views/Index.php#L95

drag and drop does not work, it needs a fix. Need to change the use of [] for arrays:

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Calendar/actions/DragDropAjax.php#L47

I think "drag and drop" should be a separate ticket to this one (but it works for me).

I can confirm the drag n drop of events in calendar view is an existing bug for vtiger 7.1 using php 7.1. So I think that makes vtiger 7.1 not compatible with php 7.1

The problem is in modules/Calendaractions/DragDropAjax.php:

The error is:

That's the code available in the latest commit. So I guess it must be an issue for vtiger 7.2 as well.

Sorry I didn't create a new issue Alan. I will try to replicate the bug on the latest master commit and open a new issue if it is still there.

This error is easy to fix. Instead of initialising the $startDateTime var as an empty string, it should be initialised as an empty array.

Looking through this file https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Calendar/actions/DragDropAjax.php I can see multiple lines where a var is:

1. initialised as an empty string (bad)
2. not initialised at all (worse), or
3. initialised as an empty array() (correct)!

It needs cleaning up and using some consistency.

Also, I note that one method relies heavily on the $_REQUEST super global. I thought v7 was supposed to drop this in favour of the Vtiger_Request class?

@lord_alan I think we are off topic. We should make a new issue for Drag&Drop

@daniel.voelskow Good point.

Ok guys, I opened a new issue: #1301 (closed)

It would be great to hear from the Vtiger Team, what the "official" compatibility and the recommended php version are. I've struggled a lot with this specific topic.

@ruben.estrada Vtiger is officially compatible with php 7.2. We would recommend the php version <= 7.2

We have addressed many signature compatible warnings, and we are on the way to do more to make it fully compatible with higher versions.

mentioned in merge request !643 (merged)

Status changed to closed by commit 37ec180f

@lord_alan @daniel.voelskow @ruben.estrada Addressed signature warnings.

mentioned in merge request !645 (merged)

mentioned in merge request !642 (merged)

mentioned in commit b5c4d979

Milestone changed to 7.3

Added php7 label

Added bug label