vtws_revise fails because of undefined function Inventory_TaxRecord_Model::getSelectedDefaultTaxMode()

See https://code.vtiger.com/vtiger/vtigercrm/blob/master/include/Webservices/LineItem/VtigerInventoryOperation.php#L228

The function Inventory_TaxRecord_Model::getSelectedDefaultTaxMode() is not defined anywhere in Vtiger. Maybe it was removed at some point.

I noticed the error when trying to use vtws_revise to edit a field of an Invoice record.

Seeing the same issue - its currently impossible to use vtws_revise on any inventory module record

@ruben.estrada If you pass 'hdnTaxType' as one of the variables to update then you can stop this function being called

@uma.s this issue is more serious as there seems to be another issue whereby when using vtws_retrieve then vtws_update on an Inventory record, it removes the LineItems element (meaning that the Quote/Invoice/SalesOrder gets saved with NO Product/Services related to it) - will raise this as a separate issue, but would like to use vtws_revise to get around it, but cannot due to this bug!

mentioned in issue #1597 (closed)

@Martin.allen What I did was to remove the call to the non existing function to fix it. I don't recall having the line items removal issue. Could it be that passing hdnTaxType would have that side effect? I will report back if I come across this again.

mentioned in issue #1604 (closed)

mentioned in issue #1633

lol - looks like this has been a bug for quite a long time:

#994 (closed)

wow, this is indeed a duplicate of #994 (closed)

Alan, I recommend using hashtag and then the issue number instead of using links, that way, a ""mentioned in issue" entry gets automatically added to the comments of the issue like so:

mentioned in issue #994 (closed)

mentioned in merge request !848 (merged)

mentioned in commit 5ba58872

mentioned in commit 5e953049

Status changed to closed by commit ea743825

@prasad maybe #994 (closed) should be closed as well.

could anyone in this thread help validate my comments in this commit: 5ba58872 ?

@ruben.estrada I suspect you forgot line items before calling revise, you should call vtws_retrieve_inventory since vtws_retrieve alone doesn't get them.

I just used vtws_revise() and passed an array with the id of a sales order together with just one field I wanted to edit. The idea of the revise function is that you don't have to pass fields you don't want to change, if I'm not mistaken. If you need to pass unchanged fields to the function, then you could just use vtws_update and forget about revise.

But maybe I'm getting something wrong here. May I ask, how do you use vtws_revise in the case of inventory modules. I've never really used it because of the bug. But from your comments I assume you've been using it successfully.

Well, you sure were too quick to judge my fix "worst than the bug itself", next time check thoroughly what you don't know, and if something seems wrong too you, ask politely

Angelo, please don't take it personal. That wasn't the intention. I just got alarmed by having that result. That's why I was asking others to help verify. The whole point of this thing is collaboration. I apologize if my comments offended you.

But back to the issue, could you please comment on this: "But maybe I'm getting something wrong here. May I ask, how do you use vtws_revise in the case of inventory modules. I've never really used it because of the bug. But from your comments I assume you've been using it successfully."