getSelectedDefaultTaxMode #1561

Finally the obnoxious error that denied vtws_create, vtws_revise and more operations, since 4 years ago, is solved. Now you don't have to patch it manually at every release anymore.

Status changed to merged

mentioned in commit 5e953049

@angelo.paglialonga @prasad why add an empty function? isn't it better to remove the call to getSelectedDefaultTaxMode() here: https://code.vtiger.com/vtiger/vtigercrm/blob/master/include/Webservices/LineItem/VtigerInventoryOperation.php#L228 ?

The function is not used anywhere else in the system. so why keep it?

Plus, you end up with an empty line items section:

Which is a far worse bug than the one being fixed!

Hi @ruben.estrada what kind of test did you do exactly to say that? Are you sure? This solution has been successfully applied in production systems for years.

@angelo.paglialonga your fix does delete the TaxType (Tax Mode in the image below) if you don't pass it in the fields provided to vtws_revise. Why? because your function provides an empty value which is used to overwrite whatever the current value is:

The line items do get deleted, but that is not related to your fix. That is another bug which should be fixed.

The point of vtws_revise is to just provide fields you need to update without touching fields you don't want to change and without getting errors for not providing mandatory fields which are currently missing in the record.

Please share your thoughts. My only goal here is to improve Vtiger. Nothing else.

Please ignore my previous comment, I didn't notice this commit had already changed the function: ea743825