Skip to content
Snippets Groups Projects
Commit 7323946a authored by Prasad's avatar Prasad
Browse files

Merge branch 'File_security' into 'master'

Migration changes has been addressed

See merge request !412
parents 4efd0c15 ee7de584
No related branches found
No related tags found
No related merge requests found
......@@ -39,6 +39,8 @@ class Migration_Module_Model extends Vtiger_Module_Model {
array('700' => '7.0.0'),
array('701' => '7.0.1'),
array('710' => '7.1.0'),
array('711' => '7.1.1'),
array('720' => '7.2.0'),
);
return $versions;
}
......
  • Nilay Khatri @nilay.automatesmb ·

    why are we not also including the File Extension for encryption?

    https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Vtiger/helpers/Util.php#L1247

  • Author Maintainer

    @nilay.automatesmb - obscurity is obtained not just with filename and extension likely won't matter.

  • Nilay Khatri @nilay.automatesmb ·

    Obscuring filename would prevent guessing the data in file or the relations.

    But if extension name is visible one could also get hints on how to play around with that file.

  • Author Maintainer

    @nilay.automatesmb - extension play important role in mime-type management. If something can guess filename with extension then the point of obscurity is defeated isn't. I will wait for more stuble reason why extension should be removed and also what impact would it bring in.

  • Nilay Khatri @nilay.automatesmb ·

    Okay, agreed for now.

    also shouldn't the storedname be encrypted in database using a key based algorithm?

  • Uma @uma.s

    mentioned in issue #1140 (closed)

    ·

    mentioned in issue #1140 (closed)

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment