Skip to content

Fix date comparison bug to get reminders

Christian Cruz Garrido requested to merge christian.cruz/vtigercrm:master into master
  1. You can't create a separate date and time comparison when getting the event reminders, as it will create an error even if the day has passed (which would be enough, in some cases), it will cause the notification to not be displayed

Example:

Date of the day:

  • Date1: 2023-07-02
  • Time1: 02:00

Date of event

  • Date2: 2022-07-01
  • Time2: 16:00

Compare: D2 < D1 && T2 < T1

2022-07-01 < 2023-07-02

16:00 < 02:00

However, in this example, despite the fact that a year has passed, the notification will not be displayed and it could be displayed if it enters at a different time

  1. The ideal is to compare date and time at the same time.

Example

Date of the day:

  • Date1: 2023-07-02 02:00

Date of event

  • Date2: 2022-07-01 16:00

Compare: D2 < D1

2022-07-01 16:00 < 2023-07-02 02:00

This fixes the issue: #1771 (closed)

Merge request reports