#1611 add lock icons for internal/external comments in related comments tab and …
…check internal comments checkbox by default.
Merge request reports
Activity
Filter activity
mentioned in issue #1611 (closed)
2823 2823 var commentTextAreaElement = closestAddCommentBlock.find('.commentcontent'); 2824 2824 var commentInfoBlock = currentTarget.closest('.singleComment'); 2825 2825 commentTextAreaElement.val(''); 2826 closestAddCommentBlock.find('#is_private').removeAttr('checked'); 2826 -
@ruben.estrada Can you please brief the intent of this change? Why was this removed?
2823 2823 var commentTextAreaElement = closestAddCommentBlock.find('.commentcontent'); 2824 2824 var commentInfoBlock = currentTarget.closest('.singleComment'); 2825 2825 commentTextAreaElement.val(''); 2826 closestAddCommentBlock.find('#is_private').removeAttr('checked'); 2826 -
sure, when you post a comment, line 2825 clears the contents of the text area input so that you can write a new comment. The intention of line 2826 is to un-check the checkbox in case it was activated by the user and bring it back to the default. In this case, we are changing the default to be checked. If we leave that line, then, after you post the first comment, the second one is going to be public by default because it will remove the selection.
mentioned in commit 5eb35cee
-
@ruben.estrada Thanks! for the fix, It's been pulled.
-
@uma.s that's great! Thak you!
Please register or sign in to reply