#1611 internal comments by default in tickets and visual cue to differentiate created comments
Merge request reports
Activity
30 30 {if in_array($MODULE_NAME, $PRIVATE_COMMENT_MODULES)} 31 31 <div class="" style="margin: 7px 0;"> 32 32 <label> 33 <input type="checkbox" id="is_private" style="margin:2px 0px -2px 0px"> {vtranslate('LBL_INTERNAL_COMMENT')} 33 <input type="checkbox" id="is_private" style="margin:2px 0px -2px 0px" checked> {vtranslate('LBL_INTERNAL_COMMENT')} 34 34 </label> -
@ruben.estrada I think it's better to enable the checkbox, Only if it's private comments module.
-
@ruben.estrada I don't see the style change for internal comment background color, Can you please verify.
30 30 {if in_array($MODULE_NAME, $PRIVATE_COMMENT_MODULES)} 31 31 <div class="" style="margin: 7px 0;"> 32 32 <label> 33 <input type="checkbox" id="is_private" style="margin:2px 0px -2px 0px"> {vtranslate('LBL_INTERNAL_COMMENT')} 33 <input type="checkbox" id="is_private" style="margin:2px 0px -2px 0px" checked> {vtranslate('LBL_INTERNAL_COMMENT')} 34 34 </label> -
yes @uma.s , if you look at line 30, you'll see that line 33 is inside an if statement that checks for that. But I'm not sure if you meant that. If no, could you please clarify a bit more?
-
@uma.s if you take look at the image I posted, you'll see that "internal comments" (the ones where I'm adding the closed lock icon) have a slightly yellow background. If you don't see it, that reinforces my argument about it not being obvious enough and leading to confusion.
Here is the exact line where the background is changed: https://code.vtiger.com/ruben.estrada/vtigercrm/blob/7.4.0/layouts/v7/modules/Vtiger/RecentComments.tpl#L74
-
@ruben.estrada Ok, that looks fine.
Thanks! for the clarification.
mentioned in commit 3e7816b7
