Fix for #1520 - Eliminate MySQL CAST on datetime columns when expected value type is datetime.

Areas validated

Querygenerators
CustomView
Reports (all types) with grouping.
Calendar

include/QueryGenerator/EnhancedQueryGenerator.php

@@ -726,7 +726,7 @@ class EnhancedQueryGenerator extends QueryGenerator {
$startDateValue = explode(' ', $values[0]);
$endDateValue = explode(' ', $values[1]);
if (count($startDateValue) == 2 && count($endDateValue) == 2) {
-							$fieldSql .= " CAST(CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) AS DATETIME) $valueSql";
+							$fieldSql .= " CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) $valueSql";
} else {
$fieldSql .= "$dateFieldColumnName $valueSql";
}
@@ -736,7 +736,7 @@ class EnhancedQueryGenerator extends QueryGenerator {
}
$values = explode(' ', $value);
if (count($values) == 2) {
-							$fieldSql .= "$fieldGlue CAST(CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) AS DATETIME) $valueSql ";
+							$fieldSql .= "$fieldGlue CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) $valueSql ";
} else {
$fieldSql .= "$fieldGlue $dateFieldColumnName $valueSql";
}