Fixes #1217 Tags details fetched for requests made via webservices
Merge request reports
Activity
mentioned in commit 7d497821
190 190 if(!$meta->hasPermission(EntityMeta::$RETRIEVE,$row["crmid"])){ 191 191 continue; 192 192 } 193 $output[] = DataTransform::sanitizeDataWithColumn($row,$meta); 193 $output[$row["crmid"]] = DataTransform::sanitizeDataWithColumn($row,$meta); -
@uma.s This causes a problem when using vtws_query with multiple results from the same module... You one get one result for each module's index columnname, e.g. [leadid] => 1234
190 190 if(!$meta->hasPermission(EntityMeta::$RETRIEVE,$row["crmid"])){ 191 191 continue; 192 192 } 193 $output[] = DataTransform::sanitizeDataWithColumn($row,$meta); 193 $output[$row["crmid"]] = DataTransform::sanitizeDataWithColumn($row,$meta); -
@lord_alan Thanks! for the note, will review this.
190 190 if(!$meta->hasPermission(EntityMeta::$RETRIEVE,$row["crmid"])){ 191 191 continue; 192 192 } 193 $output[] = DataTransform::sanitizeDataWithColumn($row,$meta); 193 $output[$row["crmid"]] = DataTransform::sanitizeDataWithColumn($row,$meta); -
@lord_alan Addressed! Please refer MR
190 190 if(!$meta->hasPermission(EntityMeta::$RETRIEVE,$row["crmid"])){ 191 191 continue; 192 192 } 193 $output[] = DataTransform::sanitizeDataWithColumn($row,$meta); 193 $output[$row["crmid"]] = DataTransform::sanitizeDataWithColumn($row,$meta); -
@uma.s That seems to work for Vlastic Search. But one thing I am not sure of, is if these changes have made any difference to the format of the output of this api call? It would be worth checking because there will be multiple extension modules and other third-party code which uses this vtws_query API. And of course the REST API as well.
190 190 if(!$meta->hasPermission(EntityMeta::$RETRIEVE,$row["crmid"])){ 191 191 continue; 192 192 } 193 $output[] = DataTransform::sanitizeDataWithColumn($row,$meta); 193 $output[$row["crmid"]] = DataTransform::sanitizeDataWithColumn($row,$meta); -
@lord_alan Verified with the format of output before and after the change, Output remains the same. Will not affect any dependencies.
We are making use of the record id index of $output to generate tags of related records. Once it's populated response retains the same format as before.