Fixes #1178 ::Uma::split api is been replaced with preg_split

Err, not sure why you are doing that? There is already a function which handles case as well. It would be better - surely to simply remove the offending function calls from the system and replace with supported calls?

https://code.vtiger.com/vtiger/vtigercrm/blob/master/include/utils/utils.php#L2326

@uma.s Sorry - might have to tag you so you get notified of the comment above.

@lord_alan I think the above code will not suit the split functionality as strpos just focus on first occurence of regex. preg_split is efficient to replace split.

Instead of replacing the offending call at many places. I feel this goes well and i have also tested with all occurence of split as attached in split_usage.txt which works fine.

But now, you have two tests like this:

Your new one in include/utils/VtlibUtils.php: if (!function_exists('split')) {

And then in include/utils/utils.php: if (!function_exists('split')) {

Which is going to "win"?

Added 1 commit:

• c89f8ac9 - Fixes #1178 (closed) split api is replaced with preg_split

@lord_alan We will be retaining VtlibUtils, Where replacing split with preg_split, Code in Utils.php is removed.

Status changed to merged