Check permission addresed on Vtiger core action files
Merge request reports
Activity
Filter activity
mentioned in commit e0461c34
13 function checkPermission(Vtiger_Request $request) { 14 return true; 13 public function requiresPermission(Vtiger_Request $request){ 14 $permissions = parent::requiresPermission($request); 15 $permissions[] = array('module_parameter' => 'module', 'action' => 'DetailView'); 16 $permissions[] = array('module_parameter' => 'custom_module', 'action' => 'DetailView'); 17 $request->set('custom_module', 'ModComments'); 18 19 return $permissions; 15 20 } 16 21 17 22 public function process(Vtiger_Request $request) { 18 $mentionRule = Settings_Notifications_Task_Model::getInstance('Mention'); 19 $message = $request->get('message'); 20 $mentionedUsers = $mentionRule->getMentionedNames($message); -
@uma.s Here you have removed the $mentionedUsers array completely. Later on in this file I believe there could be an issue if it is non-existent (see line https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Vtiger/actions/MentionedUsers.php#L36 - the "haystack" might not exist[1]). I think you should probably create an empty array at the beginning or something?
13 function checkPermission(Vtiger_Request $request) { 14 return true; 13 public function requiresPermission(Vtiger_Request $request){ 14 $permissions = parent::requiresPermission($request); 15 $permissions[] = array('module_parameter' => 'module', 'action' => 'DetailView'); 16 $permissions[] = array('module_parameter' => 'custom_module', 'action' => 'DetailView'); 17 $request->set('custom_module', 'ModComments'); 18 19 return $permissions; 15 20 } 16 21 17 22 public function process(Vtiger_Request $request) { 18 $mentionRule = Settings_Notifications_Task_Model::getInstance('Mention'); 19 $message = $request->get('message'); 20 $mentionedUsers = $mentionRule->getMentionedNames($message); -
@lord_alan Thanks! for the note, will review this.
13 function checkPermission(Vtiger_Request $request) { 14 return true; 13 public function requiresPermission(Vtiger_Request $request){ 14 $permissions = parent::requiresPermission($request); 15 $permissions[] = array('module_parameter' => 'module', 'action' => 'DetailView'); 16 $permissions[] = array('module_parameter' => 'custom_module', 'action' => 'DetailView'); 17 $request->set('custom_module', 'ModComments'); 18 19 return $permissions; 15 20 } 16 21 17 22 public function process(Vtiger_Request $request) { 18 $mentionRule = Settings_Notifications_Task_Model::getInstance('Mention'); 19 $message = $request->get('message'); 20 $mentionedUsers = $mentionRule->getMentionedNames($message); -
@lord_alan We have addressed this.Thank you! Ref
13 function checkPermission(Vtiger_Request $request) { 14 return true; 13 public function requiresPermission(Vtiger_Request $request){ 14 $permissions = parent::requiresPermission($request); 15 $permissions[] = array('module_parameter' => 'module', 'action' => 'DetailView'); 16 $permissions[] = array('module_parameter' => 'custom_module', 'action' => 'DetailView'); 17 $request->set('custom_module', 'ModComments'); 18 19 return $permissions; 15 20 } 16 21 17 22 public function process(Vtiger_Request $request) { 18 $mentionRule = Settings_Notifications_Task_Model::getInstance('Mention'); 19 $message = $request->get('message'); 20 $mentionedUsers = $mentionRule->getMentionedNames($message);
Please register or sign in to reply