Skip to content
Snippets Groups Projects

Fix for translation bug #372

Closed Alan Lord requested to merge lord_alan/vtigercrm:372_relatedListViewFix into 7.0.0

Merge request reports

Approval is optional

Closed by avatar (Mar 29, 2025 5:20pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor

    I know it's a little complicated. But in many countries in east Europa we need separate LBL_ADD_ACCOUNT, LBL_ADD_INVOICE, LBL_ADD_SO, .... Because static merge LBL_ADD and LBL_SINLGLE_MODULE_NAME create a mistake.

  • Contributor

    Or maybe use only one LBL_ADD_RECORD or LBL_ADD_RELATED_RECORD for each related module creation. I think this need a review from community, if possible.

  • Author Contributor

    Interesting point. Sure, please raise it on the mailing list and let's see if we can get input for languages where the initial proposal doesn't work right.

  • Thanks @lord_alan, Please check the commit 6053b56c

  • Author Contributor

    @satish.dvnk I really don't understand what you are doing? I created this merge request. Why do you not simply use it rather than creating a new commit which is identical? Then these things will all be linked back to the issue... As it is you have to manually tag me, to tell me you have done something.

    Please try and use the tools at your disposal more effectively.

  • Author Contributor

    And also, please note the comments from @its4you above. This fix is probably not the right thing to do for certain languages:

    Because static merge LBL_ADD and LBL_SINLGLE_MODULE_NAME create a mistake.

  • @lord_alan, While I was working with some other issue, I came to know about this issue and at the same time I committed the change set. Later, I got to know your merge request so I changed the subject(title) of my merge request and I think it's not parallel work.

  • Author Contributor

    This can probably be closed I guess? Maybe @its4you has some specific cases where singular and plural translations do not work correctly for certain languages but this merge request was "sort of" copied and then merged by @satish.dvnk 11 months ago.

  • Maintainer

    thanks @lord_alan - good to close the stalled ones. so it can re-opened with more details or file with respect latest trunk.

  • Prasad Status changed to closed

    Status changed to closed

Please register or sign in to reply
Loading