fix #1846 remove unnecessary check for colon in columName. Email template...

fix #1846 (closed) remove unnecessary check for colon in columName. Email template variables without colons did not get replaced.

In commit 73bfc813 a strict check was added to check whether columnName isset, but in addition a check for a colon (:) was also added. This is not a character that always appears in the template variables. In the case of template variable

$contacts_firstname$

in an email template, the 'firstname' does not have a colon, and thus no longer got replaced after this change.

For some more background. I am in the process of updating an existing vtiger instance running on the 7.4.0 open source version to the newest 8.3.0 version. During the testing phase after the upgrade, I ran into an issue that email campaigns I used before, did not replace the template variables.

It seems that somewhere during 7.4.0 and 8.3.0 someone added more safety checks in the email template code to prevent warnings. But it also broke some of the functionality, in case the template variables do not have this colon-separated parent/child hierarchy.

@prasad please merge this, it's really important to use mail templates with variables

mentioned in commit 8d62bb28

merged