links of type DETAILVIEWTAB in vtiger_links don't get used

modules/Vtiger/models/DetailView.php getDetailViewLinks reads links of type 'DETAILVIEWBASIC','DETAILVIEW', but not 'DETAILVIEWTAB' so, adding new functionality similar to the updates tab is not easy to do cleanly.

code to fix around line 120 would be:

            $detailViewBasicTablinks = $linkModelListDetails['DETAILVIEWTAB'];
            if(!empty($detailViewBasicTablinks)) {
                    foreach($detailViewBasicTablinks as $linkModel) {
                            $linkModelList['DETAILVIEWTAB'][] = $linkModel;
                    }
            }

Hi Alan,

Api Vtiger_Link_Model::getAllByType() with passed linktype, will only filter preferred linktypes over others. So i guess iterating over 'DETAILVIEWTAB' is not useful. Please share your thought regarding this.

Hi Uma, yes, I am adding DETAILVIEWTAB to the filter array on line 59 too so that there is something to iterate over. I will prepare a merge request in a bit

Hi Alan,

As we are making separate call inside api for getDetailViewRelatedLinks() to fetch 'DETAILVIEWTAB', What's the need to include that in linkTypes array of getDetailViewLinks() api?

mentioned in merge request !18 (closed)

getDetailViewRelatedLinks does hard coded stuff to set up the detail view/summary view /updates/comments links but it never goes to vtiger_links table to get custom ones added by modules. It doesn't call Vtiger_Link_Model::getAllByType

Hi Alan,

Thanks! for the case scenario explained on this. Please submit us the merge request will look into this.

hi, it is merge request !18 (closed)

Hi Alan,

Thanks! for the merge request, will look into pull the changes soon.

Status changed to closed

Fix pulled e684b2e3 & 442e5485

Milestone changed to 6.5.0