Module export doesn't work correctly - v6.4

In many cases exporting module (by module manager) doesn't work because wrong file size calculation my fix => at line 32 into vtlib/Vtiger/Zip.php (class Vtiger_Zip) I replaced

$zipfilesize = $disk_file_size + ($disk_file_size % 1024);

with

$zipfilesize = $disk_file_size;

the fix up above is not correct :( ... on module export, zip file on web server is already corrupted .... I'm investigating ....

thanks this post https://discussions.vtiger.com/index.php?p=/discussion/182101/export-module-doesnt-work-/p1

---

my previous fix (zipfilesize = $disk_file_size;) was for vt64

into vt65 /vtlib/thirdparty/dZip.inc.php is changed respect vt64: 3 variable references (&) dropped (Meld helps you to find those)

I'm using PHP5.6.24

---

in vt64 my first fix resolves

---

in vt65

roll-back dZip.inc.php from vt64

and replace (like vt64)

$zipfilesize = $disk_file_size;

---

to reproduce the problem

==>>> you can download and save zip file, but not unzip it ... you can browse the zip by double click, but not open single file

login at demo.vtiger.com -> go in CRM Settings -> Module Manager -> click to export PBXManager or EmailTemplates or Mail Manager

I tested on linux (firefox, chrome), android (firefox, chrome), windows (iexplorer, firefox) ... same behaviour

I have 6.5 and exported modules can not be installed on other instances

Hi Tony, I suspect problem is into

   /vtlib/thirdparty/dUnzip2.inc.php

this file was changed from vt64 to vt65 too

try to roll-back this file from vt64 too

I didn't test it. I'm giving you a blind suggest. please feedback here

AD

It works. If you are using Vtiger 6.5.x: Roll back Zip library to http://code.vtiger.com/vtiger/vtigercrm/raw/6.4.0/vtlib/thirdparty/dZip.inc.php

Then in /vtlib/Vtiger/Zip.php replace this:

$zipfilesize = $disk_file_size + ($disk_file_size % 1024);

With this:

$zipfilesize = $disk_file_size;

This is reversing a fix done 9 years ago: http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/5298#no1

There is a similar calculation in modules/Emails/actions/DownloadFile.php in case it happens that email downloads are also corrupted. Is this going to be repaired in v7?

Status changed to closed

The additional size was added due to WINOS as stated earlier:

Refer this link to know incase you still face problem of file corruption in IE but not in Firefox ​http://support.microsoft.com/kb/308090

Reverting back would mean demand for validation.

Closing this issue - to wait for reopen with more scenarios or report.

mentioned in issue #1090 (closed)