vtws_retrieve() of a User - roleid always empty.

This seems to have been a problem for many versions of vtiger.

See thread on mailing list: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2021-October/040410.html

Hi @lord_alan

do you have a patch for this? I just came across this problem :(

The problem is in DataTransform::sanitizeReferences():

		function sanitizeReferences($row,$meta){
			global $adb,$log;
			$references = $meta->getReferenceFieldDetails();
			var_dump($references);
			foreach($references as $field=>$typeList){
				if(strtolower($meta->getEntityName()) == "emails"){
					if(isset($row['parent_id'])){
						list($row['parent_id'], $fieldId) = explode('@', $row['parent_id']);
					}
				}
				if($row[$field]){
					$found = false;
					foreach ($typeList as $entity) {
						$webserviceObject = VtigerWebserviceObject::fromName($adb,$entity);
						$handlerPath = $webserviceObject->getHandlerPath();
						$handlerClass = $webserviceObject->getHandlerClass();

						require_once $handlerPath;

						$handler = new $handlerClass($webserviceObject,$meta->getUser(),$adb,$log);
						$entityMeta = $handler->getMeta();
						if($entityMeta->exists($row[$field])){
							$row[$field] = vtws_getId($webserviceObject->getEntityId(),$row[$field]);
							$found = true;
							break;
						}
					}
					if($found !== true){
						//This is needed as for query operation of the related record is deleted.
						$row[$field] = null;
					}
				//0 is the default for most of the reference fields, so handle the case and return null instead as its the 
				//only valid value, which is not a reference Id.
				}elseif(isset($row[$field]) && $row[$field]==0){
					$row[$field] = null;
				}
			}
			return $row;
		}

This line: $references = $meta->getReferenceFieldDetails(); returns something like this in the case of the Users module:

/var/www/html/vtigercrm/include/Webservices/DataTransform.php:210:
Array
(
    [roleid] => Array
        (
        )

    [reports_to_id] => Array
        (
            [0] => Users
        )

    [currency_id] => Array
        (
            [0] => Currency
        )

)

Since there is no module specified for the roleid field, then it gets set to null here:

if($found !== true){
	//This is needed as for query operation of the related record is deleted.
	$row[$field] = null;
}

This fix makes it work:

if($found !== true && $field != 'roleid'){
	//This is needed as for query operation of the related record is deleted.
	$row[$field] = null;
}

But I have no idea whether that would be an appropriate solution.

changed the description

added time estimate of

added bug label

mentioned in merge request !1141 (merged)

mentioned in commit d12db41a

closed with commit 766ce506

closed with merge request !1141 (merged)

changed milestone to %8.2.0