Google cal sync minimum date ERROR

on 7.3 I've got this error using google calendar sync:

Error calling GET https://www.googleapis.com/calendar/v3/calendars/primary/events?maxResults=100&orderBy=updated&singleEvents=true&updatedMin=2014-10-31T14%3A08%3A31Z: (410) The requested minimum modification time lies too far in the past.

mentioned in merge request !822 (closed)

@angelo.paglialonga I couldn't see any changes in the given merge request apart from re-zipping the Google package. As well it shows around 138 commits. Please do review

If it's only the packaging that cause the issue, Then that will be addressed as we will be re-packaging the file pre-release

HI @uma.s google module is zipped in pkg directory on repository, so I've added a single line in google module, and then rezipped the package, I don't know what I have to do, could you give me a direction, since there is no google module in modules directory?

@angelo.paglialonga Yes! you can't find google files inside module folder, As these are pkg files. Please do find the file inside pkg/vtiger/modules/Google folder to make necessary changes, which you need to package.

If your still confused, recommend your changes here is the discussion box. So that i can review and pull.

Calendar.php Hi @uma.s since I can't do it via git, (I've tried replacing zip file but I've got an error: "no changes made") I post it here, the file is in modules/Google/connectors/Calendar.php.

At line 155 you will find my new line: $query['updatedMin'] = date("Y-m-d", strtotime("first day of previous month"));

Thank you!

@angelo.paglialonga This change will hard-code google calendar sync time, which needs to be dynamic and read from DB vtiger_google_sync table.

Are you sure? Setting date parametric to one month ago means fixing error related to trying to sync events from 2014 and is faster .

Plus everyone I know complained about google sync pointlessly going back years ago just to sync events clients don't care anymore, what do you think?

@angelo.paglialonga Can you please point to related discussion threads, So that we can review and get into conclusion.

@uma.s well my customers didn't post about it in forum, but sure at least one vtiger consultancy vendor does use a minimum start date for sync for his "sync module", see in features list https://www.smackcoders.com/vtiger-google-calendar-sync-bi-directional.html

@angelo.paglialonga I agree with your point about pointlessly going back years ago just to sync events clients don't care anymore. Let's seek others opinion before merging this change.

@all Please do share your thoughts regarding "updatedMin" time for Google Calendar sync. If many of them struggling about google sync pointlessly going back years ago just to sync events clients don't care anymore. Then it's good to go with @angelo.paglialonga suggestion about setting it to one month prior dates.

mentioned in merge request !825 (merged)

Milestone changed to 7.4.0

mentioned in commit f51df3cb

mentioned in commit 1c7bf2c9

mentioned in commit 48b16520

Status changed to closed

Reassigned to @vtiger

Added bug label