Skip to content
Snippets Groups Projects
Commit aacce356 authored by Uma's avatar Uma
Browse files

Merge branch 'Comments_FilePreview_Addressed' into 'master'

Fixes #1321 File Preview is Comments is supported

See merge request !664
parents 2420534c 8c1908a2
No related branches found
No related tags found
No related merge requests found
Loading
  • Alan Lord @lord_alan

    mentioned in commit aacce356

    ·

    mentioned in commit aacce356

    Toggle commit list
  • Alan Lord @lord_alan ·
    Contributor

    @uma.s Also, you are running the same test if ($recordModel->get('filename')) { on lines 56 and 59... Why not only test once?

  • Uma @uma.s ·
    Author Guest

    @lord_alan Thanks! for the review, I have addressed the mentioned comments here

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment