Fixes #1094::Uma::Migration code updated to move tags from custom table to base table

modules/Migration/schema/701_to_710.php

@@ -81,23 +81,30 @@ if (defined('VTIGER_UPGRADE')) {
 
 	//START::Tag fields are pointed to cf table for the modules Assets, Services etc..
 	$fieldName = 'tags';
-	$moduleModels = Vtiger_Module_Model::getAll();
-	foreach ($moduleModels as $moduleModel) {
-		$baseTableId = $moduleModel->basetableid;
-		if ($baseTableId) {
-			$baseTableName = $moduleModel->basetable;
-			$customTableName = $baseTableName.'cf';
-			$customTableColumns = $db->getColumnNames($customTableName);
-			if (in_array($fieldName, $customTableColumns)) {
-				$fieldModel = Vtiger_Field_Model::getInstance($fieldName, $moduleModel);
-				$db->pquery("UPDATE vtiger_field SET tablename=? WHERE fieldid=?", array($baseTableName, $fieldModel->id));
-				$db->pquery("ALTER TABLE $baseTableName ADD COLUMN $fieldName VARCHAR(1)", array());
-
-				$db->pquery("UPDATE $baseTableName, $customTableName SET $baseTableName.tags=$customTableName.tags WHERE $baseTableName.$baseTableId=$customTableName.$baseTableId", array());
-				$db->pquery("ALTER TABLE $customTableName DROP COLUMN $fieldName", array());
-			}
-		}
-	}
+    $moduleModels = Vtiger_Module_Model::getAll();
+    $restrictedModules = array('Dashboard', 'Home', 'Rss', 'Portal', 'Webmails', 'Import');
+    foreach ($moduleModels as $moduleModel) {
+        if(in_array($moduleModel->getName(), $restrictedModules)) {
+            continue;
+        }
+        $moduleClass = CRMEntity::getInstance($moduleModel->getName());
+        $baseTableId = $moduleClass->table_index;
+        if ($baseTableId) {
+            $baseTableName = $moduleClass->table_name;
+            $customTable = $moduleClass->customFieldTable;
+            $customTableName = $customTable[0];
+            $customTableId = $customTable[1];
+            $customTableColumns = $db->getColumnNames($customTableName);
+            if (in_array($fieldName, $customTableColumns)) {
+                $fieldModel = Vtiger_Field_Model::getInstance($fieldName, $moduleModel);
+                $db->pquery("UPDATE vtiger_field SET tablename=? WHERE fieldid=?", array($baseTableName, $fieldModel->id));
+                $db->pquery("ALTER TABLE $baseTableName ADD COLUMN $fieldName VARCHAR(1)", array());
+
+                $db->pquery("UPDATE $baseTableName, $customTableName SET $baseTableName.tags=$customTableName.tags WHERE $baseTableName.$baseTableId=$customTableName.$customTableId", array());
+                $db->pquery("ALTER TABLE $customTableName DROP COLUMN $fieldName", array());
+            }
+        }
+    }
 	echo '<br>Succecssfully generalized tag fields<br>';
 	//END::Tag fields are pointed to cf table for the modules Assets, Services etc..
 

[Alan Lord]

@uma.s

One other thing you might want to change in piece of code is the initial Vtiger_Module_Model::getAll(); call.

As far as I understand it, tags are only relevant to entity modules so using Vtiger_Module_Model::getEntityModules(); would reduce the number of iterations which the foreach loop has to check.

In my own scripts I use the getEntityModules() method and I also added a short test for the class file before calling $moduleClass = CRMEntity::getInstance($moduleModel->getName());:

if(!class_exists($moduleName)) {
    continue;
}

I could probably remove the $restrictedModules test completely with these changes...