Merge branch 'signature-warnings' into 'master'

Fixes #1247 Signature warnings are been addressed

See merge request !554

modules/Portal/models/Module.php

@@ -21,7 +21,7 @@ class Portal_Module_Model extends Vtiger_Module_Model {
 		return $links;
 	}
     
-    public function saveRecord($recordId, $bookmarkName, $bookmarkUrl) {
+    public function saveRecord($recordId, $bookmarkName = false, $bookmarkUrl = false) {
         $db = PearDatabase::getInstance();
         if(empty($recordId)) {
             $portalId = $db->getUniqueID('vtiger_portal');

modules/Settings/ModuleManager/models/Module.php

@@ -66,8 +66,14 @@ class Settings_ModuleManager_Module_Model extends Vtiger_Module_Model {
 	 * Static Function to get the instance of Vtiger Module Model for all the modules
 	 * @return <Array> - List of Vtiger Module Model or sub class instances
 	 */
-	public static function getAll() {
-		 return parent::getAll(array(0,1), self::getNonVisibleModulesList());
+	public static function getAll($presence = array(), $restrictedModulesList = array(),$sequenced = false) {
+        if(empty($presence)){
+            $presence = array(0,1);
+        }
+        if(empty($restrictedModulesList)){
+            $restrictedModulesList = self::getNonVisibleModulesList();
+        }
+		 return parent::getAll($presence, $restrictedModulesList);
 	}
 
 	/**

modules/Vtiger/uitypes/Email.php

@@ -18,7 +18,7 @@ class Vtiger_Email_UIType extends Vtiger_Base_UIType {
 		return 'uitypes/Email.tpl';
 	}
 
-	public function getDisplayValue($value, $recordId, $recordInstance=false) {
+	public function getDisplayValue($value, $recordId = false, $recordInstance=false) {
 		$currentUser = Users_Record_Model::getCurrentUserModel();
 		$internalMailer = $currentUser->get('internal_mailer');
 		if($value){

modules/Vtiger/uitypes/UserRole.php

@@ -36,7 +36,7 @@ class Vtiger_UserRole_UIType extends Vtiger_Base_UIType {
 	 * @param <Number> $recordId
 	 * @return <String> display value
 	 */
-	public function getDisplayValue($value, $recordId) {
+	public function getDisplayValue($value, $recordId=false, $recordInstance=false) {
 		$displayValue = $this->getEditViewDisplayValue($value);
 		$currentUserModel = Users_Record_Model::getCurrentUserModel();
 		if ($currentUserModel->isAdminUser()) {