Patch to allow admins to edit/delete any Custom Views. Refs #706

Added 1 commit:

• abbae7f2 - Fix typo. Refs #706 (closed)

@uma.s This is what I've done for a couple of customers and it seems to work OK.

Title changed from WIP: Patch to allow admins to edit/delete any Custom Views. Refs #706 (closed) to Patch to allow admins to edit/delete any Custom Views. Refs #706 (closed)

I haven't looked at the tag code but presumably it will be in a similar area, so possibly this approach might work for tags too?

@lord_alan Thanks! for the patch, I will review and analyze the case with Tags and filter.

Target branch changed from master to 7.4.0

Milestone changed to 7.4.0

Reassigned to @vtiger

@lord_alan This looks good! Why can't we push this enhancement through extensions instead of making the product bulky. Please do let me known your thoughts in this regard.

@uma.s I'm not sure I understand? How can an extension override core Vtiger files?

@lord_alan Looking at the fix, I thought as it's using most of Js functionality, which can be achieved through HEADERSCRIPTS. Additionally we are binding few data attributes based on admin user which can achieved from client on page load.

Please do let me known if i missing something or my preception is not right?

@uma.s

I'm not really sure I follow your thought process here. If you review the original issue #706 you will see that it was raised 3 years ago because it was a regression. In vtiger 6 and previous, admin users could manage the lists; now they can't. This should be core functionality.

Also, determining if the current user is an admin from the client is more complicated. Then we have to re-write the lists after they have already been rendered to the dom...

@lord_alan Thanks! for the input. I will review this note on why was this removed in vtiger7 and see if we can get this functionality back.

@lord_alan We accept to pull these changes for getting back the privilege to admin users, But before that i have a query with respect to performance.

As the change gets the privilege to admin users to edit and delete the shared-lists, On larger systems there will be 100's of such lists, Will this not hinder the system performance. As you have already  experienced this on one of the customer instances, Please do share your thoughts in this perspective.

@uma.s Thanks.

I haven't had any problems reported. This patch has been running on a customer's system in the USA with > 600 users and 10s of millions of rows of data for about 6 months now.

@lord_alan Thank you!

Status changed to merged

mentioned in commit 80e40a11

@lord_alan Thanks! for the contribution, We are happy to accept the changeset.

Yay! Thanks @uma.s (what about Tags?)