Skip to content
Snippets Groups Projects

#126 : swapped default seperator for grouping to avoid same seperator for decimal and grouiping

Merged #126 : swapped default seperator for grouping to avoid same seperator for decimal and grouiping
Merged Tim Mohrbach requested to merge preexo/vtigercrm:fix_#126 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Prasad mentioned in commit eae6b325

    mentioned in commit eae6b325

  • Prasad Status changed to merged

    Status changed to merged

    • Manuel @manuelgit commented on commit 8e5c9c74
      Contributor

      Yes, and that change should be done also in modules/Users/Users.php line 751 for user creation

      Another improve (optional) is add a currency_grouping_separator "none" so we can have this: 123456,78 instead of this: 123.456,78

      Maybe opening a new ticket for this formats not show in inventory creation like quotes invoices etc

      		if(empty($this->column_fields['currency_decimal_separator'])) {
      			$this->column_fields['currency_decimal_separator'] = ',';
      		}
      
      		if(empty($this->column_fields['currency_grouping_separator'])) {
      			$this->column_fields['currency_grouping_separator'] = '.';
      		}
      

      and 1053

      $this->column_fields['currency_decimal_separator'] = $this->currency_decimal_separator = ',';
      			$this->column_fields['currency_grouping_separator'] = $this->currency_grouping_separator = '.';
    • Please register or sign in to reply
Please register or sign in to reply
Loading