Fix notices warnings
Merge request reports
Activity
Added 2 commits:
- 8ed3016e - fixing assigning by reference http://php.net/manual/en/language.operators.assign…
- e4ee3731 - fixed strict standard errors when functions were inherited with a wrong parameter count
Added 1 commit:
- 167ad11e - fixed more notices, warnings, stricts and deprecations
@prasad fair enough to defer this pull request for now. Until what time are you planning to defer it to?
There are many more changes to be made, so far it's only scratching the surface. The ultimate goal should be no more notices/warnings/stricts and everything working with PHP7. Many more dependencies (3rd party libraries) could also be updated, it's almost an entire task for itself.
Depending on this pull request I would like to pick this work again, but would defer the maintenance work for now until you found time to review this pull request. Thanks, looking forward for feedback.
Added cleanup label
mentioned in issue #197 (closed)
@manuelgit - We can continue this merge request to make it complete and push when its ready.
Please review if (7ba54539) address spliti functionality.
@manuelgit - I will only continue working on this issue once I saw this merge requests being processed. Once anything happens here I will happily continue to commit changes and improvements.
So I might just ask again: Why has this not been merged yet? What is wrong with this merge request?
Added 89 commits:
-
167ad11e...b2f90568 - 88 commits from branch
vtiger:master
- c4fc2f17 - Merge branch 'master' into fix_notices_warnings
-
167ad11e...b2f90568 - 88 commits from branch
@prasad - I understand, I cleaned the merge request, it was a tiny conflict. Please review this request and merge in case you agree with the changes. Once this is merged I will continue.
P.S.: People made some tests and according to those, warnings in PHP can slow down the execution time by factor 6... I didn't even know... (http://idiallo.com/blog/fix-all-php-warnings)
mentioned in commit 12aa4322
@preexo - You removed libraries/HTTP_Session/Session.php and updated include_once
but don't forget to update also SessionManager.php in include/Webservices/ and webservice.php in root with new libraries/HTTP_Session2/HTTP/Session2.php
Also com_vtiger_workflow.service in cron/modules/com_vtiger_workflow/
@manuelgit - Thanks a lot for reviewing, you are correct, I actually missed even more than that, added another commit !63 (merged) Please review this as well, we should probably start a ticket to keep track on the changes and reviews?