Skip to content
Snippets Groups Projects

Fix notices warnings

Merged Tim Mohrbach requested to merge preexo/vtigercrm:fix_notices_warnings into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tim Mohrbach Added 2 commits:

    Added 2 commits:

  • Tim Mohrbach Added 3 commits:

    Added 3 commits:

    • b7d70aa7 - changed functions to be static due to static calls only
    • 1ebf7ce0 - fixed function parameter count
    • b35cd45e - To fix strict warnings caused by PEAR HTTP_Session class: removed superseded PEA…
  • Author Contributor

    All of it should be reviewed at some stage, but I think this one needs a special attention review: b35cd45e

  • Tim Mohrbach Added 2 commits:

    Added 2 commits:

    • 6b6d7460 - fixed strict standard about missing parameter in abstract class
    • 328c9627 - updated php4 code to php5 code
  • Tim Mohrbach Added 1 commit:

    Added 1 commit:

    • 167ad11e - fixed more notices, warnings, stricts and deprecations
  • Tim Mohrbach Title changed from [WIP] Fix notices warnings to Fix notices warnings

    Title changed from [WIP] Fix notices warnings to Fix notices warnings

  • Maintainer

    Deferring the pull as it brings in new dependencies and changes made are across the product.

  • Author Contributor

    @prasad fair enough to defer this pull request for now. Until what time are you planning to defer it to?

    There are many more changes to be made, so far it's only scratching the surface. The ultimate goal should be no more notices/warnings/stricts and everything working with PHP7. Many more dependencies (3rd party libraries) could also be updated, it's almost an entire task for itself.

    Depending on this pull request I would like to pick this work again, but would defer the maintenance work for now until you found time to review this pull request. Thanks, looking forward for feedback.

  • Added cleanup label

  • mentioned in issue #197 (closed)

  • Contributor

    @preexo - You will continue this merge request for php7 or plan to start a new one?

    In case you will continue

    Fix Relation Query in modules/Vtiger/models/Module.php line 1352

    $newQuery = spliti('FROM', $query);

    replace with

    $newQuery = explode('from', $query);```
    
  • Maintainer

    @manuelgit - We can continue this merge request to make it complete and push when its ready.

    Please review if (7ba54539) address spliti functionality.

  • Author Contributor

    @manuelgit - I will only continue working on this issue once I saw this merge requests being processed. Once anything happens here I will happily continue to commit changes and improvements.

    So I might just ask again: Why has this not been merged yet? What is wrong with this merge request?

  • Maintainer

    @preexo - Merge request had conflicting changes, which demanded manual review. So had to defer it until its completed.

  • Tim Mohrbach Added 89 commits:

    Added 89 commits:

  • Author Contributor

    @prasad - I understand, I cleaned the merge request, it was a tiny conflict. Please review this request and merge in case you agree with the changes. Once this is merged I will continue.

    P.S.: People made some tests and according to those, warnings in PHP can slow down the execution time by factor 6... I didn't even know... (http://idiallo.com/blog/fix-all-php-warnings)

  • Prasad Status changed to merged

    Status changed to merged

  • Prasad mentioned in commit 12aa4322

    mentioned in commit 12aa4322

  • Contributor

    @preexo - You removed libraries/HTTP_Session/Session.php and updated include_once

    but don't forget to update also SessionManager.php in include/Webservices/ and webservice.php in root with new libraries/HTTP_Session2/HTTP/Session2.php

    Also com_vtiger_workflow.service in cron/modules/com_vtiger_workflow/

  • Author Contributor

    @manuelgit - Thanks a lot for reviewing, you are correct, I actually missed even more than that, added another commit !63 (merged) Please review this as well, we should probably start a ticket to keep track on the changes and reviews?

Please register or sign in to reply
Loading