Skip to content
Snippets Groups Projects

Fix for warning message in include\utils\ListViewUtils.php

in include\utils\ListViewUtils.php

change in function decode_html($str)

from if ($_REQUEST['action'] == 'Popup' ||

REQUEST[file]==Popup)toif((isset(_REQUEST['file'] == 'Popup') to if ((isset(
_REQUEST['action']) &&
REQUEST[action]==Popup)(isset(_REQUEST['action'] == 'Popup') ||(isset(
_REQUEST['action']) && $_REQUEST['file'] == 'Popup'))

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • its4you Added 1 commit:

    Added 1 commit:

  • its4you
    its4you @its4you started a thread on the diff
  • 674 674 function decode_html($str) {
    675 675 global $default_charset;
    676 676 // Direct Popup action or Ajax Popup action should be treated the same.
    677 if ($_REQUEST['action'] == 'Popup' || $_REQUEST['file'] == 'Popup')
    677 if ((isset($_REQUEST['action']) && $_REQUEST['action'] == 'Popup') || (isset($_REQUEST['file']) && $_REQUEST['file'] == 'Popup'))
  • its4you
    its4you @its4you started a thread on the diff
  • 674 674 function decode_html($str) {
    675 675 global $default_charset;
    676 676 // Direct Popup action or Ajax Popup action should be treated the same.
    677 if ($_REQUEST['action'] == 'Popup' || $_REQUEST['file'] == 'Popup')
    677 if ((isset($_REQUEST['action']) && $_REQUEST['action'] == 'Popup') || (isset($_REQUEST['file']) && $_REQUEST['file'] == 'Popup'))
    • Author Contributor

      Thanks again and I suppose this is how community should works. Review and change if there is an issue in code.

  • Thanks @nilay.automatesmb for reminding this

  • @satish.dvnk this is important as many clients have error logging to file enabled. And if so this creates GBs of log files in just a few days. With error reporting and display on, in Vtiger we get more than 3 MB of data with these repetitive errors.

  • vtigerosm Status changed to merged

    Status changed to merged

  • Please register or sign in to reply
    Loading