Show picklist color as background color for picklist value in Edit / Create view
Fixes #404 (closed) - Warning: Missing argument 4 for CRMEntity::get_dependents_list(), called in modules/Vtiger/models/Module.php on line 1500 and defined in data/CRMEntity.php on line 1870
Merge request reports
Merged by
(Mar 23, 2025 9:48am UTC)
Activity
Added 1 commit:
- bb2c7b5f - Fixes #404 (closed) - Warning: Missing argument 4 for CRMEntity::get_dependents_list(), c…
mentioned in commit c93aec5b
228 228 * @param Vtiger_Module_Model $relatedModule 229 229 * @return <String> 230 230 */ 231 public function getRelationQuery($recordId, $functionName, $relatedModule) { 231 public function getRelationQuery($recordId, $functionName, $relatedModule, $relationId) { 232 232 if ($functionName === 'get_activities') { 233 233 $userNameSql = getSqlForNameInDisplayFormat(array('first_name' => 'vtiger_users.first_name', 'last_name' => 'vtiger_users.last_name'), 'Users'); -
This code is based on an assumption and is hardcoded all over vtiger. Please see #334 (closed). The Users module vtiger_entityname.fieldname value can be changed just like any other entity module. We have customers who set the fieldname value so the system displays the username, rather than the first_name,last_name default.
-
Doesn't quite fix everything... I just loaded this commit. On the DetailView of the Quotes page, in the Documents Widget I see the following warning:
Warning: Missing argument 4 for Inventory_Module_Model::getRelationQuery(), called in modules/Vtiger/models/Relation.php on line 123 and defined in modules/Inventory/models/Module.php on line 65 -
I believe the fix for this is in Vtiger/models/Relation.php on line 123 to change the function call from this:
$query = $parentModuleModel->getRelationQuery($parentRecord->getId(), $functionName, $relatedModuleModel);to this:
$query = $parentModuleModel->getRelationQuery($parentRecord->getId(), $functionName, $relatedModuleModel, $this->getId()); -
@satish.dvnk ^^-^^
Yes @lord_alan, I will test and update you.
I tested @lord_alan and its pushed branch also, have a look http://code.vtiger.com/vtiger/vtigercrm/merge_requests/144/diffs#diff-10
-
Thanks @satish.dvnk :-)