Localized language string is missing on Workflow Condition

There missed localized language strings on the advanced filter option of workflow condition. Maybe you fixed it on the code (modules\setting\Workflows\models\field.php).

@maie, This is not an issue because in html, we have translated labels from getAdvancedFilterOptions(). On change of field, displaying condition values from getAdvancedFilterOpsByFieldType() depending on field type. So please add related strings from this getAdvancedFilterOptions() in your language file.

@satish.dvnk @maie i think this will not work like Satish said because in case you translate "has changed" to something don't forget that you have more than one "as changed" and "has changed to"

@satish.dvnk also if you add translation for 'is not' doesn't work

@manuelgit Yes, I added "is not" and other lot of strings into vtiger.php, but its doesn't work.

@maie Can you try with "is not empty". "is not" is not available in the that api

@satish.dvnk "is not empty" will work because is present in getAdvancedFilterOptions()

So, some strings are missing in getAdvancedFilterOptions() in order to be available for translation

@satish.dvnk this is a more complete function:

public static function getAdvancedFilterOptions()
    {
        return array(
            'is' => 'is',
            'is not' => 'is not',
            'contains' => 'contains',
            'does not contain' => 'does not contain',
            'starts with' => 'starts with',
            'ends with' => 'ends with',
            'equal to' => 'equal to',
            'has changed' => 'has changed',
            'has changed to' => 'has changed to',
            'is empty' => 'is empty',
            'is not empty' => 'is not empty',
            'less than' => 'less than',
            'less than hours before' => 'less than hours before',
            'less than hours later' => 'less than hours later',
            'more than hours before' => 'more than hours before',
            'more than hours later' => 'more than hours later',
            'greater than' => 'greater than',
            'does not equal' => 'does not equal',
            'less than or equal to' => 'less than or equal to',
            'greater than or equal to' => 'greater than or equal to',
            'has changed' => 'has changed',
            'before' => 'before',
            'after' => 'after',
            'between' => 'between',
            'is added' => 'is added',
            'is today' => 'is today',
            'less than days ago' => 'less than days ago',
            'more than days ago' => 'more than days ago',
            'in less than' => 'in less than',
            'in more than' => 'in more than',
            'days ago' => 'days ago',
            'days later' => 'days later',
        );
    }

Thanks @manuelgit,

Here is my suggestion

public static function getAdvancedFilterOptions() {
		return array(
			'is' => 'LBL_IS',
			'contains' => 'LBL_CONTAINS',
			'does not contain' => 'LBL_DOES_NOT_CONTAIN',
			'starts with' => 'LBL_STARTS_WITH',
			'ends with' => 'LBL_ENDS_WITH',
			'has changed' => 'LBL_HAS_CHANGED',
			'has changed to' => 'LBL_HAS_CHANGED_TO',
			'is empty' => 'LBL_IS_EMPTY',
			'is not empty' => 'LBL_IS_NOT_EMPTY',
			'less than' => 'LBL_LESS_THAN',
			'greater than' => 'LBL_GREATER_THAN',
			'does not equal' => 'LBL_NOT_EQUAL_TO',
			'less than or equal to' => 'LBL_LESS_THAN_OR_EQUAL_TO',
			'greater than or equal to' => 'LBL_GREATER_THAN_OR_EQUAL_TO',
			'has changed from' => 'LBL_HAS_CHANGED_FROM',
			'before' => 'LBL_BEFORE',
			'after' => 'LBL_AFTER',
			'between' => 'LBL_BETWEEN',
			'is added' => 'LBL_IS_ADDED',
			'equal to' => 'LBL_EQUALS',
			'is not' => 'LBL_IS_NOT',
			'is today' => 'LBL_IS_TODAY',
			'is tomorrow' => 'LBL_IS_TOMORROW',
			'is yesterday' => 'LBL_IS_YESTERDAY',
			'less than hours before' => 'LBL_LESS_THAN_HOURS_BEFORE',
			'less than hours later' => 'LBL_LESS_THAN_HOURS_LATER',
			'more than hours before' => 'LBL_MORE_THAN_HOURS_BEFORE',
			'more than hours later' => 'LBL_MORE_THAN_HOURS_LATER',
			'less than days ago' => 'LBL_LESS_THAN_DAYS_AGO',
			'less than days later' => 'LBL_LESS_THAN_DAYS_LATER',
			'more than days ago' => 'LBL_MORE_THAN_DAYS_AGO',
			'more than days later' => 'LBL_MORE_THAN_DAYS_LATER',
			'days ago' => 'LBL_DAYS_AGO',
			'days later' => 'LBL_DAYS_LATER',
			'in less than' => 'LBL_IN_LESS_THAN',
			'in more than' => 'LBL_IN_MORE_THAN',
		);
	}

@satish.dvnk yes, even better

@maie, here is the commit db2bb266

mentioned in merge request !239 (merged)

@satish.dvnk Thank you to fixed this issue. It's back to normal. And thank @manuelgit for attention to this problem.

Status changed to closed