Duplicate code in Users.php (must have been here for years)...
At first I thought this was my eyes playing tricks on me (maybe it still is?) - but these two snippets of code look identical to me...
https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Users/Users.php#L1009
// TODO - This needs to be cleaned up once default values for fields are picked up in a cleaner way.
// This is just a quick fix to ensure things doesn't start breaking when the user currency configuration is missing
if($this->column_fields['currency_grouping_pattern'] == ''
&& $this->column_fields['currency_symbol_placement'] == '') {
$this->column_fields['currency_grouping_pattern'] = $this->currency_grouping_pattern = '123,456,789';
$this->column_fields['currency_decimal_separator'] = $this->currency_decimal_separator = '.';
$this->column_fields['currency_grouping_separator'] = $this->currency_grouping_separator = ',';
$this->column_fields['currency_symbol_placement'] = $this->currency_symbol_placement = '$1.0';
}and just below it here: https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Users/Users.php#L1020
// TODO - This needs to be cleaned up once default values for fields are picked up in a cleaner way.
// This is just a quick fix to ensure things doesn't start breaking when the user currency configuration is missing
if($this->column_fields['currency_grouping_pattern'] == ''
&& $this->column_fields['currency_symbol_placement'] == '') {
$this->column_fields['currency_grouping_pattern'] = $this->currency_grouping_pattern = '123,456,789';
$this->column_fields['currency_decimal_separator'] = $this->currency_decimal_separator = '.';
$this->column_fields['currency_grouping_separator'] = $this->currency_grouping_separator = ',';
$this->column_fields['currency_symbol_placement'] = $this->currency_symbol_placement = '$1.0';
}