Another migration script bug. No color column in User module picklists
When migrating from vtiger 6.x or earlier to vtiger 7.x, in this file:
https://code.vtiger.com/vtiger/vtigercrm/blob/7.4.0/modules/Migration/schema/620_to_630.php#L46
The two lines that add 0 and 1 to the number of currency decimals is going to always fail. This is because,
- The code that adds the
color
column has not yet run, and - Even if it had, User's module picklists do not contain a color column as described here:
https://code.vtiger.com/vtiger/vtigercrm/blob/7.4.0/modules/Migration/schema/660_to_700.php#L1357
This code should be re-written to directly update the table rather than using the Settings_Picklist_Module_Model::addPicklistValues()
method. Or, alternatively, have a work around in the addPicklistValues() method when the module model is Users.
I can't see how this could have ever worked?