Fatal error on installation

I'm trying to install the latest version available using php 7.2 and I'm getting this:

Fatal error: Uncaught Error: Call to a member function set() on boolean in /var/www/html/vtigercrm/modules/Migration/schema/660_to_700.php on line 747

The issue is here:

	//Start : Change fieldLabel of description field to Description - Project module.
	$fieldId = getFieldid(getTabid('Project'), 'description');
	$fieldModel = Vtiger_Field_Model::getInstance($fieldId);
	$fieldModel->set('label', 'Description');
	$fieldModel->__update();

@prasad should I be using php 8.0 ?

Hola Ruben, I think $fieldModel is false (boolean) I would suggest to check if fieldId is not empty first.

Hi @angelo.paglialonga , Yes, that is the problem but the thing is, it is a clean new install. There shouldn't be such errors on a new install. I even tried commenting those lines and try to install again but a similar problem happened a few lines below with another field. So I just opened this issue because I didn't have the time to debug it.

There was a change to the install/migration scripts not so long ago which stopped vtiger re-installing all the modules over and over again during the process... My guess is this code might now be being run BEFORE the Project module package has been installed?

Just put a if($fieldId) { ... } around that code. The latest Project module package probably names the field correctly anyway.

@lord_alan another option would be to install those modules before the migration scripts are run (at least when it's a new install). otherwise, we have to put if statements around all those dependencies as you suggest.

The best option would be to remove the zip packages all together and have them included in the vtiger system as the other modules are. we now have to have the packages/ dir with the zipped files AND the /pkg dir with extracted zip files so they are correctly tracked by git.

How many times have the /pkg files not been kept in synchronisation with the zip packages?

Couldn't agree more Alan. Having zipped packages in the repository doesn't make any sense. Also, having the /pkg folder makes repository management awkward. Same goes for languages. whats the point in having language packages in separate folders if they are all always installed. Better put them in the /languages folder from the very beginning. But this topic has been mentioned again and again without action. So I'm not very optimistic about it :(

pkg folder will be removed during the build creation. zip files are retained in packages for standard module manager installation.

@prasad But what is the point of having these zipped module packages in the source tree? All of these modules are installed anyway so why not treat them just like Accounts, Contacts, Calendar, Leads etc?

@prasad I agree with Alan. Everything would be better if we:

1. Got rid of the zips. In general, those don't belong to code repositories. In any case, those should be generated automatically through a build script.

2. Had languages files in the languages folders and modules in the modules folders from the very beginning. That would simplify the installation process and avoid bugs like the one described here and would make git management a lot easier. What is the benefit of "installing" the modules and language packs from a zip file?

Please don't continue this unnecessary complexity.

Only those selected app/module packages during installation will be enabled. Rest are expected to loaded when required. Making the core-slim is better than keeping it heavy.

@prasad See: https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Install/models/Utils.php#L459

And

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Install/views/Index.php#L201

This code installs all modules in the packages/vtiger/mandatory, marketplace and optional directories.

So why the need for these packaged zip files? Enable/disable is done simply by toggling the "presence" column in vtiger_tab.

To go back to the original issue, my guess is that the migrations scripts are running before we get to the installModules() call, i.e.

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Migration/views/Index.php#L140

Happens after all the migration scripts in /schema have been processed.

@lord_alan from what you say I infer that toggling the checkboxes of individual modules at installation just enables or disables the modules but doesn't change the fact that all are installed. Is that right? If so, then there is NO REASON AT ALL to keep those zip files in the packages folder and the source code in the pkg folder. I'll try to make a test and see what actually happens.

+1

@ruben.estrada Yes, when you select the modules after first login, the form submit ultimately calls this method with the selected modules:

https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Users/models/Module.php#L220

You can see it simply changes the enabled/disabled status, not the actually installed status.

Well, then there's officially no reason to keep the pkg and packages folder. It makes no sense.

Today I installed vtiger 7.4.

By the time you get to this screen:

All modules have already been unziped in the modules folder.

@prasad do you think we can get rid of the packages and pkg folders? It makes no sense to keep them. They just complicate things.

We will revisit convention change in next major version.