Skip to content
Snippets Groups Projects
Commit 5633a5e5 authored by Apparao G's avatar Apparao G
Browse files

#Fixes::158016278::Appu::Company details logo vulnerability when uploading images

parents 4e690727 7a6c6add
No related branches found
No related tags found
No related merge requests found
...@@ -479,13 +479,20 @@ function vtws_CreateCompanyLogoFile($fieldname) { ...@@ -479,13 +479,20 @@ function vtws_CreateCompanyLogoFile($fieldname) {
$fileSize = $_FILES[$fieldname]['size']; $fileSize = $_FILES[$fieldname]['size'];
if($fileSize != 0) { if($fileSize != 0) {
global $root_directory; global $root_directory;
$uploaddir = $root_directory ."/test/logo/"; //Support formats allowed to upload as per CRM UI.
$binFile = $_FILES[$fieldname]['name']; $logoSupportedFormats = array('jpeg', 'jpg', 'png', 'gif', 'pjpeg', 'x-png');
$saveLogo = validateImageFile($_FILES[$fieldname]);
if($saveLogo) { $file_type_details = explode("/", $_FILES[$fieldname]['type']);
move_uploaded_file($_FILES[$fieldname]["tmp_name"], $uploaddir.$binFile); $filetype = $file_type_details['1'];
copy($uploaddir.$binFile, $uploaddir.'application.ico'); if(in_array($filetype, $logoSupportedFormats)) {
return $binFile; $uploaddir = $root_directory ."/test/logo/";
$binFile = $_FILES[$fieldname]['name'];
$saveLogo = validateImageFile($_FILES[$fieldname]);
if($saveLogo) {
move_uploaded_file($_FILES[$fieldname]["tmp_name"], $uploaddir.$binFile);
copy($uploaddir.$binFile, $uploaddir.'application.ico');
return $binFile;
}
} }
throw new WebServiceException(WebServiceErrorCode::$FAILED_TO_UPDATE, throw new WebServiceException(WebServiceErrorCode::$FAILED_TO_UPDATE,
"$fieldname wrong file type given for upload"); "$fieldname wrong file type given for upload");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment