E_ALL cleanups in Services module

include/utils/EditViewUtils.php

@@ -422,10 +422,8 @@ function getAssociatedProducts($module, $focus, $seid = '', $refModuleName = fal
     $product_Detail[1]['final_details']['discount_percentage_final'] = 0;
 	$product_Detail[1]['final_details']['discount_amount_final'] = $discount_amount_final;
 
-	if(isset($focus->column_fields)) {
-		$hdnDiscountPercent = (float) $focus->column_fields['hdnDiscountPercent'];
-		$hdnDiscountAmount	= (float) $focus->column_fields['hdnDiscountAmount'];
-	}
+		$hdnDiscountPercent = isset($focus->column_fields['hdnDiscountPercent']) ? (float) $focus->column_fields['hdnDiscountPercent'] : 0.0;
+		$hdnDiscountAmount	= isset($focus->column_fields['hdnDiscountAmount']) ? (float) $focus->column_fields['hdnDiscountAmount'] : 0.0;
 
 	if(!empty($hdnDiscountPercent)) {
 		$finalDiscount = ($subTotal*$discountPercent/100);

modules/Products/models/Record.php

@@ -178,13 +178,13 @@ class Products_Record_Model extends Vtiger_Record_Model {
 			}
 		}
 
-		$productTaxes = isset($productDetails[1]['taxes']);
+		$productTaxes = isset($productDetails[1]['taxes']) ? $productDetails[1]['taxes'] : array();
 		if (!empty ($productDetails)) {
 			$taxCount = php7_count($productTaxes);
 			$taxTotal = 0;
 
 			for($i=0; $i<$taxCount; $i++) {
-				$taxValue = isset($productTaxes[$i]['percentage']);
+				$taxValue = isset($productTaxes[$i]['percentage']) ? $productTaxes[$i]['percentage'] : array();
 
 				$taxAmount = $totalAfterDiscount * $taxValue / 100;
 				$taxTotal = $taxTotal + $taxAmount;