From 4bff56ed3ed335b7e034e4195a235c3470c8366a Mon Sep 17 00:00:00 2001 From: Uma <uma.s@vtiger.com> Date: Fri, 13 Dec 2019 11:06:24 +0530 Subject: [PATCH] Fixes #1226 Profile Save permissions is addressed --- modules/Settings/Profiles/models/Record.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/Settings/Profiles/models/Record.php b/modules/Settings/Profiles/models/Record.php index a4e4064bf..d48fda0cc 100644 --- a/modules/Settings/Profiles/models/Record.php +++ b/modules/Settings/Profiles/models/Record.php @@ -572,11 +572,11 @@ class Settings_Profiles_Record_Model extends Settings_Vtiger_Record_Model { $i = 0; $count = count($actionsIdsList); $params = array(); - $actionsInsertQuery .= 'INSERT INTO vtiger_profile2standardpermissions(profileid, tabid, operation, permissions) VALUES '; + $actionsInsertQuery = 'INSERT INTO vtiger_profile2standardpermissions(profileid, tabid, operation, permissions) VALUES '; foreach ($actionsIdsList as $actionId => $permission) { $actionEnabled = true; $permissionValue = $this->tranformInputPermissionValue($permission); - $actionsInsertQuery .= "(?, ?, ?, ?)"; + $actionsInsertQuery .= '(?, ?, ?, ?)'; array_push($params, $profileId, $tabId, $actionId, $permissionValue); if ($i !== $count-1) { @@ -585,17 +585,17 @@ class Settings_Profiles_Record_Model extends Settings_Vtiger_Record_Model { $i++; } if ($actionsIdsList) { - $db->pquery($actionsInsertQuery, array()); + $db->pquery($actionsInsertQuery, $params); } //Utility permissions $i = 0; $count = count($utilityIdsList); $params = array(); - $utilityInsertQuery .= 'INSERT INTO vtiger_profile2utility(profileid, tabid, activityid, permission) VALUES '; + $utilityInsertQuery = 'INSERT INTO vtiger_profile2utility(profileid, tabid, activityid, permission) VALUES '; foreach($utilityIdsList as $actionId => $permission) { $permissionValue = $this->tranformInputPermissionValue($permission); - $utilityInsertQuery .= "(?, ?, ?, ?)"; + $utilityInsertQuery .= '(?, ?, ?, ?)'; array_push($params, $profileId, $tabId, $actionId, $permissionValue); if ($i !== $count-1) { @@ -604,7 +604,7 @@ class Settings_Profiles_Record_Model extends Settings_Vtiger_Record_Model { $i++; } if ($utilityIdsList) { - $db->pquery($utilityInsertQuery, array()); + $db->pquery($utilityInsertQuery, $params); } } } -- GitLab