From 204e224782ff1ea2abe10a761e45691989659e71 Mon Sep 17 00:00:00 2001
From: yogeshwar <yogeshwar.g@vtigersolutions.com>
Date: Wed, 5 Jun 2024 10:34:39 +0530
Subject: [PATCH] E-All opportunity to Project Mapping

---
 modules/Settings/Leads/models/Module.php       | 2 +-
 modules/Settings/Potentials/models/Mapping.php | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/Settings/Leads/models/Module.php b/modules/Settings/Leads/models/Module.php
index 6a120d1f3..3f65a55fa 100644
--- a/modules/Settings/Leads/models/Module.php
+++ b/modules/Settings/Leads/models/Module.php
@@ -33,7 +33,7 @@ class Settings_Leads_Module_Model extends Vtiger_Module_Model {
 	 * @return <Array> list of field ids
 	 */
 	public function getMappingSupportedFieldIdsList() {
-		if (!$this->supportedFieldIdsList) {
+		if (!property_exists($this,'supportedFieldIdsList') || !$this->supportedFieldIdsList) {
 			$selectedTabidsList[] = getTabid($this->getName());
 			$restrictedFieldNames = array('campaignrelstatus');
 			$restrictedUitypes = $this->getRestrictedUitypes();
diff --git a/modules/Settings/Potentials/models/Mapping.php b/modules/Settings/Potentials/models/Mapping.php
index 923dd6cef..6b5edbac0 100644
--- a/modules/Settings/Potentials/models/Mapping.php
+++ b/modules/Settings/Potentials/models/Mapping.php
@@ -51,7 +51,7 @@ class Settings_Potentials_Mapping_Model extends Settings_Leads_Mapping_Model {
 	 * @return <Array> list of mapping details
 	 */
 	public function getMapping($editable = false) {
-		if (!$this->mapping) {
+		if (!property_exists($this,'mapping') || !$this->mapping) {
 			$db = PearDatabase::getInstance();
 			$query = 'SELECT * FROM vtiger_convertpotentialmapping';
 			if ($editable) {
@@ -95,7 +95,7 @@ class Settings_Potentials_Mapping_Model extends Settings_Leads_Mapping_Model {
 		$db = PearDatabase::getInstance();
 		$deleteMappingsList = $updateMappingsList = $createMappingsList = array();
 		foreach ($mapping as $mappingDetails) {
-			$mappingId = $mappingDetails['mappingId'];
+			$mappingId = isset($mappingDetails['mappingId']) ? $mappingDetails['mappingId'] : '';
 			if ($mappingDetails['potential']) {
 				if ($mappingId) {
 					if ((array_key_exists('deletable', $mappingDetails)) || (!$mappingDetails['project'])) {
-- 
GitLab