diff --git a/modules/Settings/Picklist/models/Module.php b/modules/Settings/Picklist/models/Module.php index 8cab658fc3e05030e46545be4610a889a88287f8..81f5e76e99a8b635bb5e9855bf4cbc2f7aec5e90 100644 --- a/modules/Settings/Picklist/models/Module.php +++ b/modules/Settings/Picklist/models/Module.php @@ -284,8 +284,10 @@ class Settings_Picklist_Module_Model extends Vtiger_Module_Model { $deleteValueList[] = ' ( roleid = "'.$roleId.'" AND '.'picklistvalueid = "'.$pickListValueId.'") '; } } - $query = 'INSERT IGNORE INTO vtiger_role2picklist (roleid,picklistvalueid,picklistid) VALUES '. implode(",", $insertValueList); - $result = $db->pquery($query, array()); + if(!empty($insertValueList)){ + $insertQuery = 'INSERT IGNORE INTO vtiger_role2picklist (roleid,picklistvalueid,picklistid) VALUES '. implode(",", $insertValueList); + $result = $db->pquery($insertQuery, array()); + } if(!empty($deleteValueList)){ $deleteQuery = 'DELETE FROM vtiger_role2picklist WHERE '.implode(' OR ',$deleteValueList);