From 0584134f427bbd2b5458e856577f2d59e89e787f Mon Sep 17 00:00:00 2001
From: satish <satish.dvnk@vtiger.com>
Date: Fri, 30 Jun 2017 14:45:16 +0530
Subject: [PATCH] Fixes #606 - vt701: Editing a Role-based picklist can crash
the module
---
modules/Vtiger/models/Field.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/Vtiger/models/Field.php b/modules/Vtiger/models/Field.php
index d945cf920..c84a1483d 100644
--- a/modules/Vtiger/models/Field.php
+++ b/modules/Vtiger/models/Field.php
@@ -1329,7 +1329,7 @@ class Vtiger_Field_Model extends Vtiger_Field {
$picklistValues = $this->getPicklistValues();
$tableName = "vtiger_$fieldName";
if (Vtiger_Utils::CheckTable($tableName)) {
- if (is_array($picklistValues)) {
+ if (is_array($picklistValues) && count($picklistValues)) {
$result = $db->pquery("SELECT $fieldName, color FROM $tableName WHERE $fieldName IN (".generateQuestionMarks($picklistValues).")", array_keys($picklistValues));
while ($row = $db->fetch_row($result)) {
$picklistColors[$row[$fieldName]] = $row['color'];
--
GitLab