From 778008028d59990e62761280152c5bcfd79dc637 Mon Sep 17 00:00:00 2001
From: prasad <prasad@vtiger.com>
Date: Wed, 28 Feb 2018 23:59:29 +0530
Subject: [PATCH] Fixes #324: Generalized moduleid lookup

---
 modules/Settings/Picklist/models/Module.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/Settings/Picklist/models/Module.php b/modules/Settings/Picklist/models/Module.php
index 21112e63..f4e97007 100644
--- a/modules/Settings/Picklist/models/Module.php
+++ b/modules/Settings/Picklist/models/Module.php
@@ -301,10 +301,11 @@ class Settings_Picklist_Module_Model extends Vtiger_Module_Model {
 
 	public static function getPicklistSupportedModules() {
 		$db = PearDatabase::getInstance();
+		$unsupportedModuleIds = array(getTabId('Users'), getTabId('Emails'));
 		$query = "SELECT distinct vtiger_tab.tablabel, vtiger_tab.name as tabname
 				  FROM vtiger_tab
 						inner join vtiger_field on vtiger_tab.tabid=vtiger_field.tabid
-				  WHERE uitype IN (15,33,16,114) and vtiger_field.tabid NOT IN (29,10)  and vtiger_tab.presence != 1 and vtiger_field.presence in (0,2)
+				  WHERE uitype IN (15,33,16,114) and vtiger_field.tabid NOT IN (". implode(',', $unsupportedModuleIds) .")  and vtiger_tab.presence != 1 and vtiger_field.presence in (0,2)
 				  ORDER BY vtiger_tab.tabid ASC";
 		$result = $db->pquery($query, array());
 
@@ -559,4 +560,4 @@ class Settings_Picklist_Module_Model extends Vtiger_Module_Model {
 		return true;
 	}
 
-}
\ No newline at end of file
+}
-- 
GitLab