From ff4df638064e75b6f31943bc79f49a030ce4517c Mon Sep 17 00:00:00 2001
From: prasad <prasad@vtiger.com>
Date: Tue, 6 Feb 2018 15:14:19 +0530
Subject: [PATCH] Fixes #723: Dropped few legacy and unused config variables.
 Retained those that can be used further.

---
 config.performance.php                     |  7 +-----
 config.template.php                        | 27 ----------------------
 modules/Install/models/ConfigFileUtils.php | 25 --------------------
 3 files changed, 1 insertion(+), 58 deletions(-)

diff --git a/config.performance.php b/config.performance.php
index ec70047f2..d40db3411 100644
--- a/config.performance.php
+++ b/config.performance.php
@@ -20,9 +20,6 @@ $PERFORMANCE_CONFIG = Array(
 	// This avoids executing the SET NAMES SQL for each query!
 	'DB_DEFAULT_CHARSET_UTF8' => true,
 
-	// Compute record change indication for each record shown on listview
-	'LISTVIEW_RECORD_CHANGE_INDICATOR' => false,
-
 	// Turn-off default sorting in ListView, could eat up time as data grows
 	'LISTVIEW_DEFAULT_SORTING' => false,
 	
@@ -38,7 +35,5 @@ $PERFORMANCE_CONFIG = Array(
 	// reduce number of ajax requests on home page, reduce this value if home page widget dont
 	// show value.
 	'HOME_PAGE_WIDGET_GROUP_SIZE' => 12,
-	//take backup legacy style, whenever an admin user logs out.
-	'LOGOUT_BACKUP' => true,
 );
-?>
\ No newline at end of file
+?>
diff --git a/config.template.php b/config.template.php
index 88b4b3848..41abe8efc 100644
--- a/config.template.php
+++ b/config.template.php
@@ -28,9 +28,6 @@ ini_set('memory_limit','512M');
 // show or hide calendar, world clock, calculator, chat and CKEditor 
 // Do NOT remove the quotes if you set these to false! 
 $CALENDAR_DISPLAY = 'true';
-$WORLD_CLOCK_DISPLAY = 'true';
-$CALCULATOR_DISPLAY = 'true';
-$CHAT_DISPLAY = 'true'; 
 $USE_RTE = 'true';
 
 // helpdesk support email id and support name (Example: 'support@vtiger.com' and 'vtiger support')
@@ -116,16 +113,9 @@ $allow_exports = 'all';
 // upload_badext default value = php, php3, php4, php5, pl, cgi, py, asp, cfm, js, vbs, html, htm
 $upload_badext = array('php', 'php3', 'php4', 'php5', 'pl', 'cgi', 'py', 'asp', 'cfm', 'js', 'vbs', 'html', 'htm', 'exe', 'bin', 'bat', 'sh', 'dll', 'phps', 'phtml', 'xhtml', 'rb', 'msi', 'jsp', 'shtml', 'sth', 'shtm');
 
-// full path to include directory including the trailing slash
-// includeDirectory default value = $root_directory..'include/
-$includeDirectory = $root_directory.'include/';
-
 // list_max_entries_per_page default value = 20
 $list_max_entries_per_page = '20';
 
-// limitpage_navigation default value = 5
-$limitpage_navigation = '5';
-
 // history_max_viewed default value = 5
 $history_max_viewed = '5';
 
@@ -139,10 +129,6 @@ $default_action = 'index';
 // default_theme default value = blue
 $default_theme = 'softed';
 
-// show or hide time to compose each page
-// calculate_response_time default value = true
-$calculate_response_time = true;
-
 // default text that is placed initially in the login form for user name
 // no default_user_name default value
 $default_user_name = '';
@@ -154,12 +140,6 @@ $default_password = '';
 // create user with default username and password
 // create_default_user default value = false
 $create_default_user = false;
-// default_user_is_admin default value = false
-$default_user_is_admin = false;
-
-// if your MySQL/PHP configuration does not support persistent connections set this to true to avoid a large performance slowdown
-// disable_persistent_connections default value = false
-$disable_persistent_connections = false;
 
 //Master currency name
 $currency_name = '_MASTER_CURRENCY_';
@@ -172,13 +152,6 @@ $default_charset = '_VT_CHARSET_';
 // default_language default value = en_us
 $default_language = '_VT_DEFAULT_LANGUAGE_';
 
-// add the language pack name to every translation string in the display.
-// translation_string_prefix default value = false
-$translation_string_prefix = false;
-
-//Option to cache tabs permissions for speed.
-$cache_tab_perms = true;
-
 //Option to hide empty home blocks if no entries.
 $display_empty_home_blocks = false;
 
diff --git a/modules/Install/models/ConfigFileUtils.php b/modules/Install/models/ConfigFileUtils.php
index f92f183cb..b5b89fc41 100644
--- a/modules/Install/models/ConfigFileUtils.php
+++ b/modules/Install/models/ConfigFileUtils.php
@@ -204,16 +204,9 @@ ini_set('memory_limit','64M');
 // files with one of these extensions will have '.txt' appended to their filename on upload
 \$upload_badext = array('php', 'php3', 'php4', 'php5', 'pl', 'cgi', 'py', 'asp', 'cfm', 'js', 'vbs', 'html', 'htm', 'exe', 'bin', 'bat', 'sh', 'dll', 'phps', 'phtml', 'xhtml', 'rb', 'msi', 'jsp', 'shtml', 'sth', 'shtm');
 
-// full path to include directory including the trailing slash
-// includeDirectory default value = \$root_directory..'include/
-\$includeDirectory = \$root_directory.'include/';
-
 // list_max_entries_per_page default value = 20
 \$list_max_entries_per_page = '20';
 
-// limitpage_navigation default value = 5
-\$limitpage_navigation = '5';
-
 // history_max_viewed default value = 5
 \$history_max_viewed = '5';
 
@@ -227,10 +220,6 @@ ini_set('memory_limit','64M');
 // default_theme default value = blue
 \$default_theme = 'softed';
 
-// show or hide time to compose each page
-// calculate_response_time default value = true
-\$calculate_response_time = true;
-
 // default text that is placed initially in the login form for user name
 // no default_user_name default value
 \$default_user_name = '';
@@ -243,13 +232,6 @@ ini_set('memory_limit','64M');
 // create_default_user default value = false
 \$create_default_user = false;
 
-// default_user_is_admin default value = false
-\$default_user_is_admin = false;
-
-// if your MySQL/PHP configuration does not support persistent connections set this to true to avoid a large performance slowdown
-// disable_persistent_connections default value = false
-\$disable_persistent_connections = false;
-
 //Master currency name
 \$currency_name = '{$this->currencyName}';
 
@@ -261,13 +243,6 @@ ini_set('memory_limit','64M');
 // default_language default value = en_us
 \$default_language = '{$this->vtDefaultLanguage}';
 
-// add the language pack name to every translation string in the display.
-// translation_string_prefix default value = false
-\$translation_string_prefix = false;
-
-//Option to cache tabs permissions for speed.
-\$cache_tab_perms = true;
-
 //Option to hide empty home blocks if no entries.
 \$display_empty_home_blocks = false;
 
-- 
GitLab