From d7b5cdcfae48191f0dbd6ea785e106dc261c75e2 Mon Sep 17 00:00:00 2001
From: satish <satish.dvnk@vtiger.com>
Date: Mon, 21 Aug 2017 15:43:37 +0530
Subject: [PATCH] Usability: allocating space between buttons in detail view

---
 .../v7/modules/Settings/Vtiger/ModuleHeader.tpl   | 15 +++++++++++----
 layouts/v7/modules/Vtiger/ModuleHeader.tpl        |  4 ++--
 layouts/v7/skins/contact/style.css                |  3 +++
 layouts/v7/skins/inventory/style.css              |  3 +++
 layouts/v7/skins/marketing/style.css              |  3 +++
 layouts/v7/skins/marketing_and_sales/style.css    |  3 +++
 layouts/v7/skins/project/style.css                |  3 +++
 layouts/v7/skins/sales/style.css                  |  3 +++
 layouts/v7/skins/support/style.css                |  3 +++
 layouts/v7/skins/tools/style.css                  |  3 +++
 10 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/layouts/v7/modules/Settings/Vtiger/ModuleHeader.tpl b/layouts/v7/modules/Settings/Vtiger/ModuleHeader.tpl
index b5f6048ae..9a96978c3 100644
--- a/layouts/v7/modules/Settings/Vtiger/ModuleHeader.tpl
+++ b/layouts/v7/modules/Settings/Vtiger/ModuleHeader.tpl
@@ -139,13 +139,20 @@
 							{/if}
 							<li>
 								<div class="settingsIcon">
-									<button type="button" class="btn btn-default module-buttons dropdown-toggle" data-toggle="dropdown" aria-expanded="false">
-										<span class="fa fa-wrench" aria-hidden="true" title="{vtranslate('LBL_SETTINGS', $MODULE)}"></span>&nbsp; <span class="caret"></span>
+									<button type="button" class="btn btn-default module-buttons dropdown-toggle" data-toggle="dropdown" aria-expanded="false" title="{vtranslate('LBL_SETTINGS', $MODULE)}">
+										<span class="fa fa-wrench" aria-hidden="true"></span>&nbsp; <span class="caret"></span>
 									</button>
 									<ul class="detailViewSetting dropdown-menu">
 										{foreach item=SETTING from=$LISTVIEW_LINKS['LISTVIEWSETTING']}
-											<li id="{$MODULE}_setings_lisview_advancedAction_{$SETTING->getLabel()}"><a href="javascript:void(0);" onclick="{$SETTING->getUrl()};">{vtranslate($SETTING->getLabel(), $QUALIFIEDMODULE)}</a></li>
-											{/foreach}
+											<li id="{$MODULE}_setings_lisview_advancedAction_{$SETTING->getLabel()}">
+												<a	{if stripos($SETTING->getUrl(), 'javascript:') === 0}
+														onclick='{$SETTING->getUrl()|substr:strlen("javascript:")};'
+													{else}
+														onclick='window.location.href="{$SETTING->getUrl()}"'
+													{/if}>
+													{vtranslate($SETTING->getLabel(), $QUALIFIEDMODULE)}</a>
+											</li>
+										{/foreach}
 									</ul>
 								</div>
 							</li>
diff --git a/layouts/v7/modules/Vtiger/ModuleHeader.tpl b/layouts/v7/modules/Vtiger/ModuleHeader.tpl
index 1bcdfb3d0..808a48899 100644
--- a/layouts/v7/modules/Vtiger/ModuleHeader.tpl
+++ b/layouts/v7/modules/Vtiger/ModuleHeader.tpl
@@ -81,8 +81,8 @@
 						{if $MODULE_SETTING_ACTIONS|@count gt 0}
 							<li>
 								<div class="settingsIcon">
-									<button type="button" class="btn btn-default module-buttons dropdown-toggle" data-toggle="dropdown" aria-expanded="false">
-										<span class="fa fa-wrench" aria-hidden="true" title="{vtranslate('LBL_SETTINGS', $MODULE)}"></span>&nbsp;{vtranslate('LBL_CUSTOMIZE', 'Reports')}&nbsp; <span class="caret"></span>
+									<button type="button" class="btn btn-default module-buttons dropdown-toggle" data-toggle="dropdown" aria-expanded="false" title="{vtranslate('LBL_SETTINGS', $MODULE)}">
+										<span class="fa fa-wrench" aria-hidden="true"></span>&nbsp;{vtranslate('LBL_CUSTOMIZE', 'Reports')}&nbsp; <span class="caret"></span>
 									</button>
 									<ul class="detailViewSetting dropdown-menu">
 										{foreach item=SETTING from=$MODULE_SETTING_ACTIONS}
diff --git a/layouts/v7/skins/contact/style.css b/layouts/v7/skins/contact/style.css
index 10c540dda..14d9c5045 100644
--- a/layouts/v7/skins/contact/style.css
+++ b/layouts/v7/skins/contact/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/inventory/style.css b/layouts/v7/skins/inventory/style.css
index 97819f208..92aeabc0c 100644
--- a/layouts/v7/skins/inventory/style.css
+++ b/layouts/v7/skins/inventory/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/marketing/style.css b/layouts/v7/skins/marketing/style.css
index e033570d9..0c054715c 100644
--- a/layouts/v7/skins/marketing/style.css
+++ b/layouts/v7/skins/marketing/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/marketing_and_sales/style.css b/layouts/v7/skins/marketing_and_sales/style.css
index d0e5f894d..7d9dda0af 100644
--- a/layouts/v7/skins/marketing_and_sales/style.css
+++ b/layouts/v7/skins/marketing_and_sales/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/project/style.css b/layouts/v7/skins/project/style.css
index 6103cbe01..2a919fdfe 100644
--- a/layouts/v7/skins/project/style.css
+++ b/layouts/v7/skins/project/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/sales/style.css b/layouts/v7/skins/sales/style.css
index 6cce81a4e..d46f53202 100644
--- a/layouts/v7/skins/sales/style.css
+++ b/layouts/v7/skins/sales/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/support/style.css b/layouts/v7/skins/support/style.css
index 42c35b1af..a027cb038 100644
--- a/layouts/v7/skins/support/style.css
+++ b/layouts/v7/skins/support/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
diff --git a/layouts/v7/skins/tools/style.css b/layouts/v7/skins/tools/style.css
index 7f5ef093f..3a0106bd2 100644
--- a/layouts/v7/skins/tools/style.css
+++ b/layouts/v7/skins/tools/style.css
@@ -1647,6 +1647,9 @@ input[type=checkbox]:checked {
 .detailViewButtoncontainer {
   padding-top: 5px;
 }
+.detailViewButtoncontainer button.btn {
+  margin: 0px 1px !important;
+}
 .detailview-header .recordBasicInfo > .info-row {
   margin-bottom: 4px;
 }
-- 
GitLab