From c60556b6fa347a05e397325226247bcfe1020fa1 Mon Sep 17 00:00:00 2001
From: Uma <uma.s@vtiger.com>
Date: Tue, 1 Oct 2019 17:22:58 +0530
Subject: [PATCH] Fixes:#1091::Uma::Report sharing has been addressed

---
 modules/Reports/models/Record.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/Reports/models/Record.php b/modules/Reports/models/Record.php
index a3f411dce..66259d386 100644
--- a/modules/Reports/models/Record.php
+++ b/modules/Reports/models/Record.php
@@ -578,16 +578,16 @@ class Reports_Record_Model extends Vtiger_Record_Model {
 			$db->pquery('INSERT INTO vtiger_reportsharing(reportid, shareid, setype) VALUES (?,?,?)',
 					array($reportId, $sharingInfo[$i]['id'], $sharingInfo[$i]['type']));
 		}
+        
+        //On every report save delete information from below tables and insert new to avoid 
+        // confusion in updating
+        $db->pquery('DELETE FROM vtiger_report_shareusers WHERE reportid=?',array($reportId));
+        $db->pquery('DELETE FROM vtiger_report_sharegroups WHERE reportid=?',array($reportId));
+        $db->pquery('DELETE FROM vtiger_report_sharerole WHERE reportid=?',array($reportId));
+        $db->pquery('DELETE FROM vtiger_report_sharers WHERE reportid=?',array($reportId));
 		
 		$members = $this->get('members',array());
 		if(!empty($members)) {
-			//On every report save delete information from below tables and insert new to avoid 
-			// confusion in updating
-			$db->pquery('DELETE FROM vtiger_report_shareusers WHERE reportid=?',array($reportId));
-			$db->pquery('DELETE FROM vtiger_report_sharegroups WHERE reportid=?',array($reportId));
-			$db->pquery('DELETE FROM vtiger_report_sharerole WHERE reportid=?',array($reportId));
-			$db->pquery('DELETE FROM vtiger_report_sharers WHERE reportid=?',array($reportId));
-
 			$noOfMembers = count($members);
 			for ($i = 0; $i < $noOfMembers; ++$i) {
 				$id = $members[$i];
-- 
GitLab