diff --git a/languages/en_us/Vtiger.php b/languages/en_us/Vtiger.php index 02418eab4d89913166e7dbc9a676e735fd62b35b..ecb68bcbcbaf1697046a4e55f77a5a5d9fa612d7 100644 --- a/languages/en_us/Vtiger.php +++ b/languages/en_us/Vtiger.php @@ -1393,6 +1393,7 @@ $languageStrings = array( 'LBL_RELATED_MODULES_PERMISSION_DENIED' => 'Related modules permission is denied', 'LBL_RECORD_PERMISSION_DENIED' => 'Record permissions denied', 'LBL_MASS_SELECT' => 'Mass Select', + 'LBL_DASHBOARD_TAB_INVALID' => 'Invalid Tab Name ', ); $jsLanguageStrings = array( diff --git a/modules/Vtiger/actions/DashBoardTab.php b/modules/Vtiger/actions/DashBoardTab.php index a67ed527c6e9b71e708cceba1c27bda80912bee4..b1a7153ab090a7707b88033cc32385d7731f8402 100644 --- a/modules/Vtiger/actions/DashBoardTab.php +++ b/modules/Vtiger/actions/DashBoardTab.php @@ -42,21 +42,24 @@ class Vtiger_DashBoardTab_Action extends Vtiger_Action_Controller { */ function addTab(Vtiger_Request $request) { $moduleName = $request->getModule(); - $tabName = $request->getRaw('tabName'); - - $dashBoardModel = Vtiger_DashBoard_Model::getInstance($moduleName); - $tabExist = $dashBoardModel->checkTabExist($tabName); - $tabLimitExceeded = $dashBoardModel->checkTabsLimitExceeded(); + $tabName = vtlib_purify($request->getRaw('tabName')); $response = new Vtiger_Response(); $response->setEmitType(Vtiger_Response::$EMIT_JSON); + if(!empty($tabName)) { + $dashBoardModel = Vtiger_DashBoard_Model::getInstance($moduleName); + $tabExist = $dashBoardModel->checkTabExist($tabName); + $tabLimitExceeded = $dashBoardModel->checkTabsLimitExceeded(); if ($tabLimitExceeded) { $response->setError(100, vtranslate('LBL_TABS_LIMIT_EXCEEDED', $moduleName)); - } else if ($tabExist) { - $response->setError(100, vtranslate('LBL_DASHBOARD_TAB_ALREADY_EXIST', $moduleName)); + } else if ($tabExist) { + $response->setError(100, vtranslate('LBL_DASHBOARD_TAB_ALREADY_EXIST', $moduleName)); + } else { + $tabData = $dashBoardModel->addTab($tabName); + $response->setResult($tabData); + } } else { - $tabData = $dashBoardModel->addTab($tabName); - $response->setResult($tabData); + $response->setError(100, vtranslate('LBL_DASHBOARD_TAB_INVALID', $moduleName)); } $response->emit(); }