From 969491f79277bc10f6a7b2171b6ad612273b4a5f Mon Sep 17 00:00:00 2001
From: Ricardo <ricardo.rodrigues@code80.co.uk>
Date: Wed, 21 Aug 2019 09:59:21 +0200
Subject: [PATCH] fix #1166 service contract create through webservice takes 2
minutes
---
.../modules/ServiceContracts/ServiceContracts.php | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/pkg/vtiger/modules/ServiceContracts/modules/ServiceContracts/ServiceContracts.php b/pkg/vtiger/modules/ServiceContracts/modules/ServiceContracts/ServiceContracts.php
index 1f9225c0e..ce8574994 100644
--- a/pkg/vtiger/modules/ServiceContracts/modules/ServiceContracts/ServiceContracts.php
+++ b/pkg/vtiger/modules/ServiceContracts/modules/ServiceContracts/ServiceContracts.php
@@ -533,6 +533,9 @@ class ServiceContracts extends CRMEntity {
$contractStatus = $this->column_fields['contract_status'];
+ $myServiceContractExistADO = $this->db->pquery('SELECT if (EXISTS (select vsc.servicecontractsid from vtiger_servicecontracts vsc WHERE vsc.servicecontractsid = ?), 1, 0) AS ex', array($this->id));
+ $ServiceContractExistFlag = isset($myServiceContractExistADO->fields['ex']) ? $myServiceContractExistADO->fields['ex'] : "1";
+
// Update the End date if the status is Complete or if the Used Units reaches/exceeds Total Units
// We need to do this first to make sure Actual duration is computed properly
if($contractStatus == 'Complete' || (!empty($usedUnits) && !empty($totalUnits) && $usedUnits >= $totalUnits)) {
@@ -542,7 +545,9 @@ class ServiceContracts extends CRMEntity {
}
} else {
$endDate = null;
- $this->db->pquery('UPDATE vtiger_servicecontracts SET end_date=? WHERE servicecontractsid = ?', array(null, $this->id));
+ if ( $ServiceContractExistFlag !== "0") {
+ $this->db->pquery('UPDATE vtiger_servicecontracts SET end_date=? WHERE servicecontractsid = ?', array(null, $this->id));
+ }
}
// Calculate the Planned Duration based on Due date and Start date. (in days)
@@ -575,7 +580,9 @@ class ServiceContracts extends CRMEntity {
if(count($updateCols) > 0) {
$updateQuery = 'UPDATE vtiger_servicecontracts SET '. implode(",", $updateCols) .' WHERE servicecontractsid = ?';
array_push($updateParams, $this->id);
- $this->db->pquery($updateQuery, $updateParams);
+ if ( $ServiceContractExistFlag !== "0") {
+ $this->db->pquery($updateQuery, $updateParams);
+ }
}
}
--
GitLab