From 5a631fa5c32bbece61eb655393ae7d60a9fe4ebb Mon Sep 17 00:00:00 2001
From: Prasad <prasad@vtiger.com>
Date: Sun, 28 Apr 2024 08:09:17 +0530
Subject: [PATCH] Fixes #1555: Loose coupled Project and Potentials with
existence check
---
modules/Potentials/models/DetailView.php | 2 +-
modules/Potentials/models/Record.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/Potentials/models/DetailView.php b/modules/Potentials/models/DetailView.php
index c96b5a860..3d1652752 100644
--- a/modules/Potentials/models/DetailView.php
+++ b/modules/Potentials/models/DetailView.php
@@ -86,7 +86,7 @@ class Potentials_DetailView_Model extends Vtiger_DetailView_Model {
);
}
- if($currentUserModel->hasModuleActionPermission($projectModuleModel->getId(), 'CreateView') && !$recordModel->isPotentialConverted()) {
+ if($projectModuleModel && $currentUserModel->hasModuleActionPermission($projectModuleModel->getId(), 'CreateView') && !$recordModel->isPotentialConverted()) {
$basicActionLink = array(
'linktype' => 'DETAILVIEWBASIC',
'linklabel' => vtranslate('LBL_CREATE_PROJECT', $recordModel->getModuleName()),
diff --git a/modules/Potentials/models/Record.php b/modules/Potentials/models/Record.php
index d4526bceb..00ea2c9db 100644
--- a/modules/Potentials/models/Record.php
+++ b/modules/Potentials/models/Record.php
@@ -99,7 +99,7 @@ class Potentials_Record_Model extends Vtiger_Record_Model {
}
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);
- if ($moduleModel->isActive()) {
+ if ($moduleModel && $moduleModel->isActive()) {
$fieldModels = $moduleModel->getFields();
foreach ($fieldModels as $fieldName => $fieldModel) {
if($fieldModel->isMandatory() && !in_array($fieldName, array('assigned_user_id', 'potentialid'))) {
--
GitLab