From d76740b5cb9a18e43f4cf0bad035bc22d7e9fe00 Mon Sep 17 00:00:00 2001 From: "chaitanya@vtiger.com" <chaitanya@vtiger.com> Date: Wed, 29 May 2024 14:29:42 +0530 Subject: [PATCH] E_All cleanups in Service module --- include/utils/EditViewUtils.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/utils/EditViewUtils.php b/include/utils/EditViewUtils.php index 046e961da..64fcd6c58 100755 --- a/include/utils/EditViewUtils.php +++ b/include/utils/EditViewUtils.php @@ -373,7 +373,6 @@ function getAssociatedProducts($module, $focus, $seid = '', $refModuleName = fal $tax_label = $tax_details[$tax_count]['taxlabel']; $tax_value = 0; - $tax_value = $tax_details[$tax_count]['percentage']; if($focus->id != '' && $taxtype == 'individual') { $lineItemId = $adb->query_result($result, $i-1, 'lineitem_id'); @@ -423,7 +422,7 @@ function getAssociatedProducts($module, $focus, $seid = '', $refModuleName = fal $product_Detail[1]['final_details']['discount_percentage_final'] = 0; $product_Detail[1]['final_details']['discount_amount_final'] = $discount_amount_final; - if(isset($focus->column_fields) && isset($focus->column_fields['hdnDiscountPercent'])) { + if(is_array($focus->column_fields)) { $hdnDiscountPercent = (float) $focus->column_fields['hdnDiscountPercent']; $hdnDiscountAmount = (float) $focus->column_fields['hdnDiscountAmount']; } -- GitLab