Unable to create Events if STRICT_ALL_TABLES enabled

If you have the above setting enabled for MySQL there is a bug in the modules/Calendar/Activity.php file in the INSERT query around line 218:

$callback_query = "INSERT INTO vtiger_activity_reminder_popup (recordid, semodule, date_start, time_start) VALUES (?,?,?,?)";

Because the status column is not defined (and the settings for this column are NOT NULL with no default value) the query fails and the whole transaction rolls back resulting in a "Record is not found" error if in Edit or if using the Quick Create it just dies silently and you get no event creation which is even worse IMHO.

I "fixed" this for the customer where we saw the issue by adding a DEFAULT value to the table of "0":

ALTER TABLE `vtiger_activity_reminder_popup` CHANGE `status` `status` INT( 2 ) NOT NULL DEFAULT '0';

I'm not sure if the correct way to address this is with a default value or if the code should be changed to populate the column as it is in the UPDATE query above it around line 214.

@lord_alan Thanks for notifying us. We will try to update this table through the migration patch.

Reassigned to @manu.k

Fixed with 88ee083a

Status changed to closed

@prasad I think this problem will be more widespread than just the saving of Events... I think there will be other places where STRICT_ALL will cause problems. Perhaps #105 (closed) could also be an example...

In recent releases of CentOS and Suse this setting is now the default for MySQL.

Milestone changed to 6.5.0

mentioned in issue #202 (closed)

mentioned in issue #202 (closed)

mentioned in issue #202 (closed)